pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_dump: fix failure to dump comments on constraints in some cas
Date: Wed, 02 Nov 2022 15:30:11 +0000
Message-ID: <E1oqFgy-0007cy-1b@gemulon.postgresql.org> (raw)

pg_dump: fix failure to dump comments on constraints in some cases.

Thinko in commit 5209c0ba0: I checked the wrong object's
DUMP_COMPONENT_COMMENT bit in two places.

Per bug #17675 from Franz-Josef Färber.

Discussion: https://postgr.es/m/17675-c69c001e06390867@postgresql.org

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0eede9625659d47a9b3fb1292f71c8b16667326b

Modified Files
--------------
src/bin/pg_dump/pg_dump.c        |  4 ++--
src/bin/pg_dump/t/002_pg_dump.pl | 15 +++++++++++----
2 files changed, 13 insertions(+), 6 deletions(-)



view thread (2+ messages)

Message-ID: <E1oqFgy-0007cy-1b@gemulon.postgresql.org>
Permalink:  ../E1oqFgy-0007cy-1b@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oqFgy-0007cy-1b@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: pg_dump: fix failure to dump comments on constraints in some cas
  In-Reply-To: <E1oqFgy-0007cy-1b@gemulon.postgresql.org>
  References: <E1oqFgy-0007cy-1b@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox