pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Create FKs properly when attaching table as partition
5+ messages / 1 participants
[nested] [flat]

* pgsql: Create FKs properly when attaching table as partition
@ 2022-11-03 19:41 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 5+ messages in thread

From: Alvaro Herrera @ 2022-11-03 19:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Create FKs properly when attaching table as partition

Commit f56f8f8da6af added some code in CloneFkReferencing that's way too
lax about a Constraint node it manufactures, not initializing enough
struct members -- initially_valid in particular was forgotten.  This
causes some FKs in partitions added by ALTER TABLE ATTACH PARTITION to
be marked as not validated.  Set initially_valid true, which fixes the
bug.

While at it, make the struct initialization more complete.  Very similar
code was added in two other places by the same commit; make them all
follow the same pattern for consistency, though no bugs are apparent
there.

This bug has never been reported: I only happened to notice while
working on commit 614a406b4ff1.  The test case that was added there with
the improper result is repaired.

Backpatch to 12.

Discussion: https://postgr.es/m/20221005105523.bhuhkdx4olajboof@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b0284bfb1db5f71778f123754f2eab362b198993

Modified Files
--------------
src/backend/commands/tablecmds.c          | 46 +++++++++++++++++++++++++------
src/test/regress/expected/foreign_key.out |  4 +--
2 files changed, 40 insertions(+), 10 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* pgsql: Create FKs properly when attaching table as partition
@ 2022-11-03 19:41 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 5+ messages in thread

From: Alvaro Herrera @ 2022-11-03 19:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Create FKs properly when attaching table as partition

Commit f56f8f8da6af added some code in CloneFkReferencing that's way too
lax about a Constraint node it manufactures, not initializing enough
struct members -- initially_valid in particular was forgotten.  This
causes some FKs in partitions added by ALTER TABLE ATTACH PARTITION to
be marked as not validated.  Set initially_valid true, which fixes the
bug.

While at it, make the struct initialization more complete.  Very similar
code was added in two other places by the same commit; make them all
follow the same pattern for consistency, though no bugs are apparent
there.

This bug has never been reported: I only happened to notice while
working on commit 614a406b4ff1.  The test case that was added there with
the improper result is repaired.

Backpatch to 12.

Discussion: https://postgr.es/m/20221005105523.bhuhkdx4olajboof@alvherre.pgsql

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c301e1c0c09cfedce9eb469744384a6d15e50745

Modified Files
--------------
src/backend/commands/tablecmds.c          | 46 +++++++++++++++++++++++++------
src/test/regress/expected/foreign_key.out |  4 +--
2 files changed, 40 insertions(+), 10 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* pgsql: Create FKs properly when attaching table as partition
@ 2022-11-03 19:41 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 5+ messages in thread

From: Alvaro Herrera @ 2022-11-03 19:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Create FKs properly when attaching table as partition

Commit f56f8f8da6af added some code in CloneFkReferencing that's way too
lax about a Constraint node it manufactures, not initializing enough
struct members -- initially_valid in particular was forgotten.  This
causes some FKs in partitions added by ALTER TABLE ATTACH PARTITION to
be marked as not validated.  Set initially_valid true, which fixes the
bug.

While at it, make the struct initialization more complete.  Very similar
code was added in two other places by the same commit; make them all
follow the same pattern for consistency, though no bugs are apparent
there.

This bug has never been reported: I only happened to notice while
working on commit 614a406b4ff1.  The test case that was added there with
the improper result is repaired.

Backpatch to 12.

Discussion: https://postgr.es/m/20221005105523.bhuhkdx4olajboof@alvherre.pgsql

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/18865f4df9ca2369f42f98d53fc0e82e38b8a41d

Modified Files
--------------
src/backend/commands/tablecmds.c          | 43 +++++++++++++++++++++++++------
src/test/regress/expected/foreign_key.out |  4 +--
2 files changed, 37 insertions(+), 10 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* pgsql: Create FKs properly when attaching table as partition
@ 2022-11-03 19:41 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 5+ messages in thread

From: Alvaro Herrera @ 2022-11-03 19:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Create FKs properly when attaching table as partition

Commit f56f8f8da6af added some code in CloneFkReferencing that's way too
lax about a Constraint node it manufactures, not initializing enough
struct members -- initially_valid in particular was forgotten.  This
causes some FKs in partitions added by ALTER TABLE ATTACH PARTITION to
be marked as not validated.  Set initially_valid true, which fixes the
bug.

While at it, make the struct initialization more complete.  Very similar
code was added in two other places by the same commit; make them all
follow the same pattern for consistency, though no bugs are apparent
there.

This bug has never been reported: I only happened to notice while
working on commit 614a406b4ff1.  The test case that was added there with
the improper result is repaired.

Backpatch to 12.

Discussion: https://postgr.es/m/20221005105523.bhuhkdx4olajboof@alvherre.pgsql

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/41b6e7c9a32e16f134622663e77060541c0e46a9

Modified Files
--------------
src/backend/commands/tablecmds.c          | 43 +++++++++++++++++++++++++------
src/test/regress/expected/foreign_key.out |  4 +--
2 files changed, 37 insertions(+), 10 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* pgsql: Create FKs properly when attaching table as partition
@ 2022-11-03 19:41 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 5+ messages in thread

From: Alvaro Herrera @ 2022-11-03 19:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Create FKs properly when attaching table as partition

Commit f56f8f8da6af added some code in CloneFkReferencing that's way too
lax about a Constraint node it manufactures, not initializing enough
struct members -- initially_valid in particular was forgotten.  This
causes some FKs in partitions added by ALTER TABLE ATTACH PARTITION to
be marked as not validated.  Set initially_valid true, which fixes the
bug.

While at it, make the struct initialization more complete.  Very similar
code was added in two other places by the same commit; make them all
follow the same pattern for consistency, though no bugs are apparent
there.

This bug has never been reported: I only happened to notice while
working on commit 614a406b4ff1.  The test case that was added there with
the improper result is repaired.

Backpatch to 12.

Discussion: https://postgr.es/m/20221005105523.bhuhkdx4olajboof@alvherre.pgsql

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ab70b3a52fde6f0519fc74f1aae1d7ad88cb16dd

Modified Files
--------------
src/backend/commands/tablecmds.c          | 43 +++++++++++++++++++++++++------
src/test/regress/expected/foreign_key.out |  4 +--
2 files changed, 37 insertions(+), 10 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread


end of thread, other threads:[~2022-11-03 19:41 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-11-03 19:41 pgsql: Create FKs properly when attaching table as partition Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-11-03 19:41 pgsql: Create FKs properly when attaching table as partition Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-11-03 19:41 pgsql: Create FKs properly when attaching table as partition Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-11-03 19:41 pgsql: Create FKs properly when attaching table as partition Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-11-03 19:41 pgsql: Create FKs properly when attaching table as partition Alvaro Herrera <alvherre@alvh.no-ip.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox