From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Create FKs properly when attaching table as partition
Date: Thu, 03 Nov 2022 19:41:59 +0000
Message-ID: <E1oqg6B-000IOC-GD@gemulon.postgresql.org> (raw)
Create FKs properly when attaching table as partition
Commit f56f8f8da6af added some code in CloneFkReferencing that's way too
lax about a Constraint node it manufactures, not initializing enough
struct members -- initially_valid in particular was forgotten. This
causes some FKs in partitions added by ALTER TABLE ATTACH PARTITION to
be marked as not validated. Set initially_valid true, which fixes the
bug.
While at it, make the struct initialization more complete. Very similar
code was added in two other places by the same commit; make them all
follow the same pattern for consistency, though no bugs are apparent
there.
This bug has never been reported: I only happened to notice while
working on commit 614a406b4ff1. The test case that was added there with
the improper result is repaired.
Backpatch to 12.
Discussion: https://postgr.es/m/20221005105523.bhuhkdx4olajboof@alvherre.pgsql
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/41b6e7c9a32e16f134622663e77060541c0e46a9
Modified Files
--------------
src/backend/commands/tablecmds.c | 43 +++++++++++++++++++++++++------
src/test/regress/expected/foreign_key.out | 4 +--
2 files changed, 37 insertions(+), 10 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org
Subject: Re: pgsql: Create FKs properly when attaching table as partition
In-Reply-To: <E1oqg6B-000IOC-GD@gemulon.postgresql.org>
References: <E1oqg6B-000IOC-GD@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox