From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Produce more-optimal plans for bitmap scans on boolean columns.
Date: Tue, 08 Nov 2022 15:36:21 +0000
Message-ID: <E1osQeC-000Bit-IJ@gemulon.postgresql.org> (raw)
Produce more-optimal plans for bitmap scans on boolean columns.
The planner simplifies boolean comparisons such as "x = true" and
"x = false" down to "x" and "NOT x" respectively, to have a canonical
form to ease comparisons. However, if we want to use an index on x,
the index AM APIs require us to reconstitute the comparison-operator
form of the indexqual. While that works, in bitmap indexscans the
canonical form of the qual was emitted as a "filter" condition
although it really only needs to be a "recheck" condition, because
create_bitmap_scan_plan didn't recognize the equivalence of that
form with the generated indexqual. booleq() is pretty cheap so that
likely doesn't make very much difference, but it's unsightly so
let's clean it up.
To fix, add a case to predicate_implied_by() to recognize the
equivalence of such clauses. This is a relatively low-cost place to
add a check, and perhaps it will have additional use cases in future.
Richard Guo and Tom Lane, per discussion of bug #17618 from Sindy
Senorita.
Discussion: https://postgr.es/m/17618-7a2240bfaa7e84ae@postgresql.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/042c9091f0fc131d001516bafc9ce334fe20d711
Modified Files
--------------
contrib/btree_gin/expected/bool.out | 14 ++++++++++-
contrib/btree_gin/sql/bool.sql | 2 ++
src/backend/optimizer/util/predtest.c | 46 ++++++++++++++++++++++++++++++++++-
3 files changed, 60 insertions(+), 2 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Produce more-optimal plans for bitmap scans on boolean columns.
In-Reply-To: <E1osQeC-000Bit-IJ@gemulon.postgresql.org>
References: <E1osQeC-000Bit-IJ@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox