pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Report a more useful error for reloptions on a partitioned table
Date: Wed, 09 Nov 2022 17:28:38 +0000
Message-ID: <E1ososP-000LkG-6v@gemulon.postgresql.org> (raw)

Report a more useful error for reloptions on a partitioned table.

Previously, trying to set storage parameters on a partitioned table
always led to "unrecognized parameter foo", because the code expected
there might be some valid parameters; but there aren't any.  The docs
make clear that it's intended that there never will be any, so let's
replace this useless search with a more to-the-point message.

Simon Riggs and Karina Litskevich

Discussion: https://postgr.es/m/CANbhV-H=eZ9kTR9mUgKGK0Qv9uXP=U+dQg3rinQHfTdFMhBA2A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4f981df8e0b7bc00d22ab0db65579589c9d4bb8c

Modified Files
--------------
src/backend/access/common/reloptions.c     | 13 ++++++-------
src/test/regress/expected/alter_table.out  |  4 ++++
src/test/regress/expected/create_table.out |  4 ++++
src/test/regress/sql/alter_table.sql       |  3 +++
src/test/regress/sql/create_table.sql      |  3 +++
5 files changed, 20 insertions(+), 7 deletions(-)



Message-ID: <E1ososP-000LkG-6v@gemulon.postgresql.org>
Permalink:  ../E1ososP-000LkG-6v@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ososP-000LkG-6v@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Report a more useful error for reloptions on a partitioned table
  In-Reply-To: <E1ososP-000LkG-6v@gemulon.postgresql.org>
  References: <E1ososP-000LkG-6v@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox