pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix comments atop ReorderBufferAddInvalidations.
Date: Thu, 10 Nov 2022 12:01:49 +0000
Message-ID: <E1ot6Fg-000SdI-Dh@gemulon.postgresql.org> (raw)

Fix comments atop ReorderBufferAddInvalidations.

The comments atop seem to indicate that we always accumulate invalidation
messages in a top-level transaction which is neither required nor matches
with the code.

Author: Amit Kapila
Reviewd by: Masahiko Sawada
Backpatch-through: 14, where it was introduced in commit c55040ccd0
Discussion: https://postgr.es/m/CAA4eK1LxGgnUroPz8STb6OfjVU1yaHoSA+T63URwmGCLdMJ0LA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/36e545cd051ffe58064c1f38faeb64f4feef4aec

Modified Files
--------------
src/backend/replication/logical/reorderbuffer.c | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)



view thread (3+ messages)

Message-ID: <E1ot6Fg-000SdI-Dh@gemulon.postgresql.org>
Permalink:  ../E1ot6Fg-000SdI-Dh@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ot6Fg-000SdI-Dh@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org
  Subject: Re: pgsql: Fix comments atop ReorderBufferAddInvalidations.
  In-Reply-To: <E1ot6Fg-000SdI-Dh@gemulon.postgresql.org>
  References: <E1ot6Fg-000SdI-Dh@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox