pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix comments atop ReorderBufferAddInvalidations.
3+ messages / 1 participants
[nested] [flat]

* pgsql: Fix comments atop ReorderBufferAddInvalidations.
@ 2022-11-10 12:01 Amit Kapila <akapila@postgresql.org>
  0 siblings, 0 replies; 3+ messages in thread

From: Amit Kapila @ 2022-11-10 12:01 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix comments atop ReorderBufferAddInvalidations.

The comments atop seem to indicate that we always accumulate invalidation
messages in a top-level transaction which is neither required nor matches
with the code.

Author: Amit Kapila
Reviewd by: Masahiko Sawada
Backpatch-through: 14, where it was introduced in commit c55040ccd0
Discussion: https://postgr.es/m/CAA4eK1LxGgnUroPz8STb6OfjVU1yaHoSA+T63URwmGCLdMJ0LA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/36e545cd051ffe58064c1f38faeb64f4feef4aec

Modified Files
--------------
src/backend/replication/logical/reorderbuffer.c | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Fix comments atop ReorderBufferAddInvalidations.
@ 2022-11-10 12:01 Amit Kapila <akapila@postgresql.org>
  0 siblings, 0 replies; 3+ messages in thread

From: Amit Kapila @ 2022-11-10 12:01 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix comments atop ReorderBufferAddInvalidations.

The comments atop seem to indicate that we always accumulate invalidation
messages in a top-level transaction which is neither required nor matches
with the code.

Author: Amit Kapila
Reviewd by: Masahiko Sawada
Backpatch-through: 14, where it was introduced in commit c55040ccd0
Discussion: https://postgr.es/m/CAA4eK1LxGgnUroPz8STb6OfjVU1yaHoSA+T63URwmGCLdMJ0LA@mail.gmail.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/daadb42e92ed903642bce314e9c7a0325ee6b1b2

Modified Files
--------------
src/backend/replication/logical/reorderbuffer.c | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Fix comments atop ReorderBufferAddInvalidations.
@ 2022-11-10 12:01 Amit Kapila <akapila@postgresql.org>
  0 siblings, 0 replies; 3+ messages in thread

From: Amit Kapila @ 2022-11-10 12:01 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix comments atop ReorderBufferAddInvalidations.

The comments atop seem to indicate that we always accumulate invalidation
messages in a top-level transaction which is neither required nor matches
with the code.

Author: Amit Kapila
Reviewd by: Masahiko Sawada
Backpatch-through: 14, where it was introduced in commit c55040ccd0
Discussion: https://postgr.es/m/CAA4eK1LxGgnUroPz8STb6OfjVU1yaHoSA+T63URwmGCLdMJ0LA@mail.gmail.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/fc0d1ecb0bf1b0d9f8271b81735a8eb8b304ad70

Modified Files
--------------
src/backend/replication/logical/reorderbuffer.c | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2022-11-10 12:01 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-11-10 12:01 pgsql: Fix comments atop ReorderBufferAddInvalidations. Amit Kapila <akapila@postgresql.org>
2022-11-10 12:01 pgsql: Fix comments atop ReorderBufferAddInvalidations. Amit Kapila <akapila@postgresql.org>
2022-11-10 12:01 pgsql: Fix comments atop ReorderBufferAddInvalidations. Amit Kapila <akapila@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox