pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: If wait_for_catchup fails under has_wal_read_bug, skip balance o
2+ messages / 1 participants
[nested] [flat]

* pgsql: If wait_for_catchup fails under has_wal_read_bug, skip balance o
@ 2022-11-12 19:24  Noah Misch <noah@leadboat.com>
  0 siblings, 0 replies; 2+ messages in thread

From: Noah Misch @ 2022-11-12 19:24 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

If wait_for_catchup fails under has_wal_read_bug, skip balance of test.

Test files should now ignore has_wal_read_bug() so long as
wait_for_catchup() is their only known way of reaching the bug.  That's
at least five files today, a number expected to grow over time.  This
commit removes skip logic from three.  By doing so, systems having the
bug regain the ability to catch other kinds of defects via those three
tests.  The other two, 002_databases.pl and 031_recovery_conflict.pl,
have been unprotected.  Back-patch to v15, where done_testing() first
became our standard.

Discussion: https://postgr.es/m/20221030031639.GA3082137@rfd.leadboat.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e5f94d42eb38f39af81f934d70c3969913f2862e

Modified Files
--------------
contrib/bloom/t/001_wal.pl                   |  7 -------
src/test/perl/PostgreSQL/Test/Cluster.pm     | 19 +++++++++++++++++--
src/test/recovery/t/027_stream_regress.pl    |  7 -------
src/test/recovery/t/032_relfilenode_reuse.pl |  7 -------
4 files changed, 17 insertions(+), 23 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: If wait_for_catchup fails under has_wal_read_bug, skip balance o
@ 2022-11-12 19:24  Noah Misch <noah@leadboat.com>
  0 siblings, 0 replies; 2+ messages in thread

From: Noah Misch @ 2022-11-12 19:24 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

If wait_for_catchup fails under has_wal_read_bug, skip balance of test.

Test files should now ignore has_wal_read_bug() so long as
wait_for_catchup() is their only known way of reaching the bug.  That's
at least five files today, a number expected to grow over time.  This
commit removes skip logic from three.  By doing so, systems having the
bug regain the ability to catch other kinds of defects via those three
tests.  The other two, 002_databases.pl and 031_recovery_conflict.pl,
have been unprotected.  Back-patch to v15, where done_testing() first
became our standard.

Discussion: https://postgr.es/m/20221030031639.GA3082137@rfd.leadboat.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/30d98e14a88930c6d9658525fd5e6722e70a02e6

Modified Files
--------------
contrib/bloom/t/001_wal.pl                   |  7 -------
src/test/perl/PostgreSQL/Test/Cluster.pm     | 19 +++++++++++++++++--
src/test/recovery/t/027_stream_regress.pl    |  7 -------
src/test/recovery/t/032_relfilenode_reuse.pl |  7 -------
4 files changed, 17 insertions(+), 23 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2022-11-12 19:24 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-11-12 19:24 pgsql: If wait_for_catchup fails under has_wal_read_bug, skip balance o Noah Misch <noah@leadboat.com>
2022-11-12 19:24 pgsql: If wait_for_catchup fails under has_wal_read_bug, skip balance o Noah Misch <noah@leadboat.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox