From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: If wait_for_catchup fails under has_wal_read_bug, skip balance o
Date: Sat, 12 Nov 2022 19:24:05 +0000
Message-ID: <E1otw6m-000oEn-FU@gemulon.postgresql.org> (raw)
If wait_for_catchup fails under has_wal_read_bug, skip balance of test.
Test files should now ignore has_wal_read_bug() so long as
wait_for_catchup() is their only known way of reaching the bug. That's
at least five files today, a number expected to grow over time. This
commit removes skip logic from three. By doing so, systems having the
bug regain the ability to catch other kinds of defects via those three
tests. The other two, 002_databases.pl and 031_recovery_conflict.pl,
have been unprotected. Back-patch to v15, where done_testing() first
became our standard.
Discussion: https://postgr.es/m/20221030031639.GA3082137@rfd.leadboat.com
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e5f94d42eb38f39af81f934d70c3969913f2862e
Modified Files
--------------
contrib/bloom/t/001_wal.pl | 7 -------
src/test/perl/PostgreSQL/Test/Cluster.pm | 19 +++++++++++++++++--
src/test/recovery/t/027_stream_regress.pl | 7 -------
src/test/recovery/t/032_relfilenode_reuse.pl | 7 -------
4 files changed, 17 insertions(+), 23 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: noah@leadboat.com
Subject: Re: pgsql: If wait_for_catchup fails under has_wal_read_bug, skip balance o
In-Reply-To: <E1otw6m-000oEn-FU@gemulon.postgresql.org>
References: <E1otw6m-000oEn-FU@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox