pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Make PostgreSQL::Test::Cluster::config_data more flexible
2+ messages / 1 participants
[nested] [flat]

* pgsql: Make PostgreSQL::Test::Cluster::config_data more flexible
@ 2022-11-13 14:04  Andrew Dunstan <andrew@dunslane.net>
  0 siblings, 0 replies; 2+ messages in thread

From: Andrew Dunstan @ 2022-11-13 14:04 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make PostgreSQL::Test::Cluster::config_data more flexible

Currently this only allows for one argument, which must be present, and
always returns a single string. With this change the following now all
work:

  $all_config = $node->config_data;
  %config_map = ($node->config_data);
  $incdir = $node->config_data('--include-dir');
  ($incdir, $sharedir) = $node->config_data(
      qw(--include-dir --share-dir));

Backpatch to release 15 where this was introduced.

Discussion: https://postgr.es/m/73eea68e-3b6f-5f63-6024-25ed26b52016@dunslane.net

Reviewed by Tom Lane, Alvaro Herrera, Michael Paquier.

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7a387f513d6c583b1c3fe5e4e0ea2b8cb92c85da

Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 43 ++++++++++++++++++++++++++------
1 file changed, 35 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Make PostgreSQL::Test::Cluster::config_data more flexible
@ 2022-11-13 14:04  Andrew Dunstan <andrew@dunslane.net>
  0 siblings, 0 replies; 2+ messages in thread

From: Andrew Dunstan @ 2022-11-13 14:04 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make PostgreSQL::Test::Cluster::config_data more flexible

Currently this only allows for one argument, which must be present, and
always returns a single string. With this change the following now all
work:

  $all_config = $node->config_data;
  %config_map = ($node->config_data);
  $incdir = $node->config_data('--include-dir');
  ($incdir, $sharedir) = $node->config_data(
      qw(--include-dir --share-dir));

Backpatch to release 15 where this was introduced.

Discussion: https://postgr.es/m/73eea68e-3b6f-5f63-6024-25ed26b52016@dunslane.net

Reviewed by Tom Lane, Alvaro Herrera, Michael Paquier.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a688c39e1dca56490527ccac13ea4ac752c7116a

Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 43 ++++++++++++++++++++++++++------
1 file changed, 35 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2022-11-13 14:04 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-11-13 14:04 pgsql: Make PostgreSQL::Test::Cluster::config_data more flexible Andrew Dunstan <andrew@dunslane.net>
2022-11-13 14:04 pgsql: Make PostgreSQL::Test::Cluster::config_data more flexible Andrew Dunstan <andrew@dunslane.net>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox