pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Make PostgreSQL::Test::Cluster::config_data more flexible
Date: Sun, 13 Nov 2022 14:04:14 +0000
Message-ID: <E1ouDao-0001Dy-0P@gemulon.postgresql.org> (raw)

Make PostgreSQL::Test::Cluster::config_data more flexible

Currently this only allows for one argument, which must be present, and
always returns a single string. With this change the following now all
work:

  $all_config = $node->config_data;
  %config_map = ($node->config_data);
  $incdir = $node->config_data('--include-dir');
  ($incdir, $sharedir) = $node->config_data(
      qw(--include-dir --share-dir));

Backpatch to release 15 where this was introduced.

Discussion: https://postgr.es/m/73eea68e-3b6f-5f63-6024-25ed26b52016@dunslane.net

Reviewed by Tom Lane, Alvaro Herrera, Michael Paquier.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a688c39e1dca56490527ccac13ea4ac752c7116a

Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 43 ++++++++++++++++++++++++++------
1 file changed, 35 insertions(+), 8 deletions(-)



view thread (2+ messages)

Message-ID: <E1ouDao-0001Dy-0P@gemulon.postgresql.org>
Permalink:  ../E1ouDao-0001Dy-0P@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ouDao-0001Dy-0P@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net
  Subject: Re: pgsql: Make PostgreSQL::Test::Cluster::config_data more flexible
  In-Reply-To: <E1ouDao-0001Dy-0P@gemulon.postgresql.org>
  References: <E1ouDao-0001Dy-0P@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox