pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: libpq: Handle NegotiateProtocolVersion message
Date: Thu, 17 Nov 2022 14:47:56 +0000
Message-ID: <E1ovgBH-000c36-TO@gemulon.postgresql.org> (raw)

libpq: Handle NegotiateProtocolVersion message

Before, receiving a NegotiateProtocolVersion message would result in a
confusing error message like

    expected authentication request from server, but received v

This adds proper handling of this protocol message and produces an
on-topic error message from it.

Reviewed-by: Jacob Champion <jchampion@timescale.com>
Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/f9c7862f-b864-8ef7-a861-c4638c83e209%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bbf9c282ce92272ed7bf6771daf0f9efa209e61b

Modified Files
--------------
src/interfaces/libpq/fe-connect.c   | 22 +++++++++++----
src/interfaces/libpq/fe-protocol3.c | 55 +++++++++++++++++++++++++++++++++++++
src/interfaces/libpq/libpq-int.h    |  1 +
3 files changed, 73 insertions(+), 5 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1ovgBH-000c36-TO@gemulon.postgresql.org>
Permalink:  ../E1ovgBH-000c36-TO@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ovgBH-000c36-TO@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: libpq: Handle NegotiateProtocolVersion message
  In-Reply-To: <E1ovgBH-000c36-TO@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox