pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix version comparison in Version.pm
Date: Fri, 18 Nov 2022 13:49:42 +0000
Message-ID: <E1ow1kT-000kHQ-Kx@gemulon.postgresql.org> (raw)

Fix version comparison in Version.pm

Version strings with unequal numbers of parts were being compared
incorrectly. We cure this by treating a missing part in the shorter
version as 0.

per complaint from Jehan-Guillaume de Rorthais, but the fix is mine, not
his.

Discussion: https://postgr.es/m/20220628225325.53d97b8d@karst

Backpatch to release 14 where this code was introduced.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/97ee956416e9d7906cde49cae5f65763ea943e77

Modified Files
--------------
src/test/perl/PostgreSQL/Version.pm | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1ow1kT-000kHQ-Kx@gemulon.postgresql.org>
Permalink:  ../E1ow1kT-000kHQ-Kx@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ow1kT-000kHQ-Kx@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net
  Subject: Re: pgsql: Fix version comparison in Version.pm
  In-Reply-To: <E1ow1kT-000kHQ-Kx@gemulon.postgresql.org>
  References: <E1ow1kT-000kHQ-Kx@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox