pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Disable debug_discard_caches in test_oat_hooks test.
Date: Sat, 19 Nov 2022 18:43:01 +0000
Message-ID: <E1owSns-000uGH-Uy@gemulon.postgresql.org> (raw)

Disable debug_discard_caches in test_oat_hooks test.

The test output varies when debug_discard_caches is enabled,
because that causes extra executions of recomputeNamespacePath.
Maybe putting a hook in that was a bad idea, but as a stopgap,
just turn off debug_discard_caches in this test.

Per buildfarm (now that we have debug_discard_caches coverage
again).  Back-patch to v15 where this module was added.

Discussion: https://postgr.es/m/2267406.1668804934@sss.pgh.pa.us

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ad0867314daa8181031071f316f4c85e87755718

Modified Files
--------------
src/test/modules/test_oat_hooks/expected/test_oat_hooks.out | 4 ++++
src/test/modules/test_oat_hooks/sql/test_oat_hooks.sql      | 5 +++++
2 files changed, 9 insertions(+)



view thread (2+ messages)

Message-ID: <E1owSns-000uGH-Uy@gemulon.postgresql.org>
Permalink:  ../E1owSns-000uGH-Uy@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1owSns-000uGH-Uy@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Disable debug_discard_caches in test_oat_hooks test.
  In-Reply-To: <E1owSns-000uGH-Uy@gemulon.postgresql.org>
  References: <E1owSns-000uGH-Uy@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox