pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Disable debug_discard_caches in test_oat_hooks test.
2+ messages / 1 participants
[nested] [flat]

* pgsql: Disable debug_discard_caches in test_oat_hooks test.
@ 2022-11-19 18:43 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 2+ messages in thread

From: Tom Lane @ 2022-11-19 18:43 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Disable debug_discard_caches in test_oat_hooks test.

The test output varies when debug_discard_caches is enabled,
because that causes extra executions of recomputeNamespacePath.
Maybe putting a hook in that was a bad idea, but as a stopgap,
just turn off debug_discard_caches in this test.

Per buildfarm (now that we have debug_discard_caches coverage
again).  Back-patch to v15 where this module was added.

Discussion: https://postgr.es/m/2267406.1668804934@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3efc82e28951c6eee24aead056b8478cb424af2e

Modified Files
--------------
src/test/modules/test_oat_hooks/expected/test_oat_hooks.out | 4 ++++
src/test/modules/test_oat_hooks/sql/test_oat_hooks.sql      | 5 +++++
2 files changed, 9 insertions(+)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Disable debug_discard_caches in test_oat_hooks test.
@ 2022-11-19 18:43 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 2+ messages in thread

From: Tom Lane @ 2022-11-19 18:43 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Disable debug_discard_caches in test_oat_hooks test.

The test output varies when debug_discard_caches is enabled,
because that causes extra executions of recomputeNamespacePath.
Maybe putting a hook in that was a bad idea, but as a stopgap,
just turn off debug_discard_caches in this test.

Per buildfarm (now that we have debug_discard_caches coverage
again).  Back-patch to v15 where this module was added.

Discussion: https://postgr.es/m/2267406.1668804934@sss.pgh.pa.us

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ad0867314daa8181031071f316f4c85e87755718

Modified Files
--------------
src/test/modules/test_oat_hooks/expected/test_oat_hooks.out | 4 ++++
src/test/modules/test_oat_hooks/sql/test_oat_hooks.sql      | 5 +++++
2 files changed, 9 insertions(+)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2022-11-19 18:43 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-11-19 18:43 pgsql: Disable debug_discard_caches in test_oat_hooks test. Tom Lane <tgl@sss.pgh.pa.us>
2022-11-19 18:43 pgsql: Disable debug_discard_caches in test_oat_hooks test. Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox