From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert "Prevent instability in contrib/pageinspect's regression
Date: Mon, 21 Nov 2022 20:40:47 +0000
Message-ID: <E1oxDaw-000GEy-6g@gemulon.postgresql.org> (raw)
Revert "Prevent instability in contrib/pageinspect's regression test."
This reverts commit 5cda142bb9d2bd7e7ed1c22ae89afe58abfa8d7b
(in v14 only).
It turns out that that fails under force_parallel_mode = regress,
because pageinspect's disk-access functions are marked parallel
safe, which they are not if you try to use them on a temp table.
The cost of fixing that pre-v15 seems to exceed the value of
making this test case fully stable, so we will just leave things
as-is in v14.
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/47a22dc2cb89aca2e54c9cf9fe2da4a5e8ba4cb4
Modified Files
--------------
contrib/pageinspect/expected/page.out | 3 +--
contrib/pageinspect/sql/page.sql | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Revert "Prevent instability in contrib/pageinspect's regression
In-Reply-To: <E1oxDaw-000GEy-6g@gemulon.postgresql.org>
References: <E1oxDaw-000GEy-6g@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox