pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline. 6+ messages / 1 participants [nested] [flat]
* pgsql: Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline. @ 2022-11-21 22:07 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-11-21 22:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline. I just spent an annoying amount of time reverse-engineering the 100%-undocumented API between ts_headline and the text search parser's prsheadline function. Add some commentary about that while it's fresh in mind. Also remove some unused macros in wparser_def.c. While at it, I noticed that when commit 78e73e875 added a CHECK_FOR_INTERRUPTS call in TS_execute_recurse, it missed doing so in the parallel function TS_phrase_execute, which surely needs one just as much. Back-patch because of the missing CHECK_FOR_INTERRUPTS. Might as well back-patch the rest of this too. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/5644d6f909b1bc92155741064275cda82d9b9b70 Modified Files -------------- src/backend/tsearch/ts_parse.c | 13 ++++++++ src/backend/tsearch/wparser_def.c | 4 --- src/backend/utils/adt/tsvector_op.c | 3 ++ src/include/tsearch/ts_public.h | 61 ++++++++++++++++++++++++++----------- 4 files changed, 60 insertions(+), 21 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline. @ 2022-11-21 22:07 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-11-21 22:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline. I just spent an annoying amount of time reverse-engineering the 100%-undocumented API between ts_headline and the text search parser's prsheadline function. Add some commentary about that while it's fresh in mind. Also remove some unused macros in wparser_def.c. While at it, I noticed that when commit 78e73e875 added a CHECK_FOR_INTERRUPTS call in TS_execute_recurse, it missed doing so in the parallel function TS_phrase_execute, which surely needs one just as much. Back-patch because of the missing CHECK_FOR_INTERRUPTS. Might as well back-patch the rest of this too. Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/74670688faaec94d9177ac182c5516c5f1a7bb9c Modified Files -------------- src/backend/tsearch/ts_parse.c | 13 ++++++++ src/backend/tsearch/wparser_def.c | 4 --- src/backend/utils/adt/tsvector_op.c | 3 ++ src/include/tsearch/ts_public.h | 61 ++++++++++++++++++++++++++----------- 4 files changed, 60 insertions(+), 21 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline. @ 2022-11-21 22:07 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-11-21 22:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline. I just spent an annoying amount of time reverse-engineering the 100%-undocumented API between ts_headline and the text search parser's prsheadline function. Add some commentary about that while it's fresh in mind. Also remove some unused macros in wparser_def.c. While at it, I noticed that when commit 78e73e875 added a CHECK_FOR_INTERRUPTS call in TS_execute_recurse, it missed doing so in the parallel function TS_phrase_execute, which surely needs one just as much. Back-patch because of the missing CHECK_FOR_INTERRUPTS. Might as well back-patch the rest of this too. Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c0eed88914c0986e0c64c9d0944c89e1c5bdb1e3 Modified Files -------------- src/backend/tsearch/ts_parse.c | 13 ++++++++ src/backend/tsearch/wparser_def.c | 4 --- src/backend/utils/adt/tsvector_op.c | 3 ++ src/include/tsearch/ts_public.h | 61 ++++++++++++++++++++++++++----------- 4 files changed, 60 insertions(+), 21 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline. @ 2022-11-21 22:07 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-11-21 22:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline. I just spent an annoying amount of time reverse-engineering the 100%-undocumented API between ts_headline and the text search parser's prsheadline function. Add some commentary about that while it's fresh in mind. Also remove some unused macros in wparser_def.c. While at it, I noticed that when commit 78e73e875 added a CHECK_FOR_INTERRUPTS call in TS_execute_recurse, it missed doing so in the parallel function TS_phrase_execute, which surely needs one just as much. Back-patch because of the missing CHECK_FOR_INTERRUPTS. Might as well back-patch the rest of this too. Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1b9c04b1389b0e8ee7f493477c22c25f65a2f89a Modified Files -------------- src/backend/tsearch/ts_parse.c | 13 ++++++++ src/backend/tsearch/wparser_def.c | 4 --- src/backend/utils/adt/tsvector_op.c | 3 ++ src/include/tsearch/ts_public.h | 61 ++++++++++++++++++++++++++----------- 4 files changed, 60 insertions(+), 21 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline. @ 2022-11-21 22:07 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-11-21 22:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline. I just spent an annoying amount of time reverse-engineering the 100%-undocumented API between ts_headline and the text search parser's prsheadline function. Add some commentary about that while it's fresh in mind. Also remove some unused macros in wparser_def.c. While at it, I noticed that when commit 78e73e875 added a CHECK_FOR_INTERRUPTS call in TS_execute_recurse, it missed doing so in the parallel function TS_phrase_execute, which surely needs one just as much. Back-patch because of the missing CHECK_FOR_INTERRUPTS. Might as well back-patch the rest of this too. Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1aed4c4fd22b5643ac681be3d9617c4c7b1b0a19 Modified Files -------------- src/backend/tsearch/ts_parse.c | 13 ++++++++ src/backend/tsearch/wparser_def.c | 4 --- src/backend/utils/adt/tsvector_op.c | 3 ++ src/include/tsearch/ts_public.h | 61 ++++++++++++++++++++++++++----------- 4 files changed, 60 insertions(+), 21 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline. @ 2022-11-21 22:07 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-11-21 22:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline. I just spent an annoying amount of time reverse-engineering the 100%-undocumented API between ts_headline and the text search parser's prsheadline function. Add some commentary about that while it's fresh in mind. Also remove some unused macros in wparser_def.c. While at it, I noticed that when commit 78e73e875 added a CHECK_FOR_INTERRUPTS call in TS_execute_recurse, it missed doing so in the parallel function TS_phrase_execute, which surely needs one just as much. Back-patch because of the missing CHECK_FOR_INTERRUPTS. Might as well back-patch the rest of this too. Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0353db996e37c6b923863ee648f4d2f153bf619d Modified Files -------------- src/backend/tsearch/ts_parse.c | 13 ++++++++ src/backend/tsearch/wparser_def.c | 4 --- src/backend/utils/adt/tsvector_op.c | 3 ++ src/include/tsearch/ts_public.h | 61 ++++++++++++++++++++++++++----------- 4 files changed, 60 insertions(+), 21 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2022-11-21 22:07 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-11-21 22:07 pgsql: Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline. Tom Lane <tgl@sss.pgh.pa.us> 2022-11-21 22:07 pgsql: Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline. Tom Lane <tgl@sss.pgh.pa.us> 2022-11-21 22:07 pgsql: Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline. Tom Lane <tgl@sss.pgh.pa.us> 2022-11-21 22:07 pgsql: Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline. Tom Lane <tgl@sss.pgh.pa.us> 2022-11-21 22:07 pgsql: Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline. Tom Lane <tgl@sss.pgh.pa.us> 2022-11-21 22:07 pgsql: Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox