pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline.
Date: Mon, 21 Nov 2022 22:07:46 +0000
Message-ID: <E1oxEx7-000GqQ-9C@gemulon.postgresql.org> (raw)

Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline.

I just spent an annoying amount of time reverse-engineering the
100%-undocumented API between ts_headline and the text search
parser's prsheadline function.  Add some commentary about that
while it's fresh in mind.  Also remove some unused macros in
wparser_def.c.

While at it, I noticed that when commit 78e73e875 added a
CHECK_FOR_INTERRUPTS call in TS_execute_recurse, it missed
doing so in the parallel function TS_phrase_execute, which
surely needs one just as much.

Back-patch because of the missing CHECK_FOR_INTERRUPTS.
Might as well back-patch the rest of this too.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5644d6f909b1bc92155741064275cda82d9b9b70

Modified Files
--------------
src/backend/tsearch/ts_parse.c      | 13 ++++++++
src/backend/tsearch/wparser_def.c   |  4 ---
src/backend/utils/adt/tsvector_op.c |  3 ++
src/include/tsearch/ts_public.h     | 61 ++++++++++++++++++++++++++-----------
4 files changed, 60 insertions(+), 21 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1oxEx7-000GqQ-9C@gemulon.postgresql.org>
Permalink:  ../E1oxEx7-000GqQ-9C@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oxEx7-000GqQ-9C@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline.
  In-Reply-To: <E1oxEx7-000GqQ-9C@gemulon.postgresql.org>
  References: <E1oxEx7-000GqQ-9C@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox