pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Create memory context for tokenization after opening top-level f
Date: Thu, 24 Nov 2022 01:28:23 +0000
Message-ID: <E1oy12M-000ZEt-Uw@gemulon.postgresql.org> (raw)

Create memory context for tokenization after opening top-level file in hba.c

The memory context was created before attempting to open the first HBA
or ident file, which would cause it to leak.  This had no consequences
for the system views for HBA and ident files, but this would cause
memory leaks in the postmaster on reload if the initial HBA and/or ident
files are missing, which is a valid behavior while the backend is
running.

Oversight in efc9816.

Author: Ted Yu
Discussion: https://postgr.es/m/CALte62xH6ivgiKKzPRJgfekPZC6FKLB3xbnf3=tZmc_gKj78dw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d46ad72f464beafa6d92d60d214412374559e280

Modified Files
--------------
src/backend/libpq/hba.c | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)



Message-ID: <E1oy12M-000ZEt-Uw@gemulon.postgresql.org>
Permalink:  ../E1oy12M-000ZEt-Uw@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oy12M-000ZEt-Uw@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Create memory context for tokenization after opening top-level f
  In-Reply-To: <E1oy12M-000ZEt-Uw@gemulon.postgresql.org>
  References: <E1oy12M-000ZEt-Uw@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox