From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add TAP tests for include directives in HBA end ident files
Date: Mon, 28 Nov 2022 06:22:51 +0000
Message-ID: <E1ozXXW-0017qW-UO@gemulon.postgresql.org> (raw)
Add TAP tests for include directives in HBA end ident files
This commit adds a basic set of authentication tests to check after the
new keywords added by a54b658 for the HBA and ident files, aka
"include", "include_if_exists" and "include_dir".
This includes checks for all the positive cases originally proposed,
where valid contents are generated for the HBA and ident files without
any errors happening in the server, checking as well the contents of
their respective system views. The error handling will be evaluated
separately (-DEXEC_BACKEND makes that trickier), and what we have here
covers most of the ground I would like to see covered if one manipulates
the tokenization logic of hba.c in the future.
While on it, some coverage is added for files included with '@' for
database or user name lists.
Author: Julien Rouhaud
Reviewed-by: Michael Paquier
Discussion: https://postgr.es/m/20220223045959.35ipdsvbxcstrhya@jrouhaud
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/cbe6e482d7bf851c6e466697a21dcef7b05cbb59
Modified Files
--------------
src/test/authentication/meson.build | 1 +
src/test/authentication/t/004_file_inclusion.pl | 298 ++++++++++++++++++++++++
2 files changed, 299 insertions(+)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz
Subject: Re: pgsql: Add TAP tests for include directives in HBA end ident files
In-Reply-To: <E1ozXXW-0017qW-UO@gemulon.postgresql.org>
References: <E1ozXXW-0017qW-UO@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox