pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove promote_trigger_file.
Date: Mon, 28 Nov 2022 23:12:48 +0000
Message-ID: <E1oznIt-001DZ5-Dp@gemulon.postgresql.org> (raw)

Remove promote_trigger_file.

Previously, an idle startup (recovery) process would wake up every 5
seconds to have a chance to poll for promote_trigger_file, even if that
GUC was not configured.  That promotion triggering mechanism was
effectively superseded by pg_ctl promote and pg_promote() a long time
ago.  There probably aren't many users left and it's very easy to change
to the modern mechanisms, so we agreed to remove the feature.

This is part of a campaign to reduce wakeups on idle systems.

Author: Simon Riggs <simon.riggs@enterprisedb.com>
Reviewed-by: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Reviewed-by: Thomas Munro <thomas.munro@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Ian Lawrence Barwick <barwick@gmail.com>
Discussion: https://postgr.es/m/CANbhV-FsjnzVOQGBpQ589%3DnWuL1Ex0Ykn74Nh1hEjp2usZSR5g%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cd4329d9393f84dce34f0bd2dd936adc8ffaa213

Modified Files
--------------
.../sgml/appendix-obsolete-recovery-config.sgml    | 13 ++---
doc/src/sgml/config.sgml                           | 18 -------
doc/src/sgml/high-availability.sgml                | 22 +++------
src/backend/access/transam/xlogrecovery.c          | 57 ++++++----------------
src/backend/utils/misc/guc_tables.c                | 10 ----
src/backend/utils/misc/postgresql.conf.sample      |  1 -
src/include/access/xlogrecovery.h                  |  1 -
7 files changed, 29 insertions(+), 93 deletions(-)



Message-ID: <E1oznIt-001DZ5-Dp@gemulon.postgresql.org>
Permalink:  ../E1oznIt-001DZ5-Dp@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oznIt-001DZ5-Dp@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org
  Subject: Re: pgsql: Remove promote_trigger_file.
  In-Reply-To: <E1oznIt-001DZ5-Dp@gemulon.postgresql.org>
  References: <E1oznIt-001DZ5-Dp@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox