From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Stop accessing checkAsUser via RTE in some cases
Date: Wed, 30 Nov 2022 11:08:26 +0000
Message-ID: <E1p0Kx0-001QLw-17@gemulon.postgresql.org> (raw)
Stop accessing checkAsUser via RTE in some cases
A future commit will move the checkAsUser field from RangeTblEntry
to a new node that, unlike RTEs, will only be created for tables
mentioned in the query but not for the inheritance child relations
added to the query by the planner. So, checkAsUser value for a
given child relation will have to be obtained by referring to that
for its ancestor mentioned in the query.
In preparation, it seems better to expand the use of RelOptInfo.userid
during planning in place of rte->checkAsUser so that there will be
fewer places to adjust for the above change.
Given that the child-to-ancestor mapping is not available during the
execution of a given "child" ForeignScan node, add a checkAsUser
field to ForeignScan to carry the child relation's RelOptInfo.userid.
Author: Amit Langote <amitlangote09@gmail.com>
Discussion: https://postgr.es/m/CA+HiwqGFCs2uq7VRKi7g+FFKbP6Ea_2_HkgZb2HPhUfaAKT3ng@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/599b33b9492dfefd1219c1d31801f40b3ba90b0d
Modified Files
--------------
contrib/postgres_fdw/postgres_fdw.c | 18 +++++++-----------
src/backend/executor/execMain.c | 2 +-
src/backend/optimizer/plan/createplan.c | 6 +++++-
src/backend/rewrite/rowsecurity.c | 2 +-
src/backend/statistics/extended_stats.c | 6 +++---
src/backend/utils/adt/selfuncs.c | 29 ++++++++++++++++++-----------
src/backend/utils/misc/rls.c | 2 +-
src/include/nodes/pathnodes.h | 2 +-
src/include/nodes/plannodes.h | 2 ++
9 files changed, 39 insertions(+), 30 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org
Subject: Re: pgsql: Stop accessing checkAsUser via RTE in some cases
In-Reply-To: <E1p0Kx0-001QLw-17@gemulon.postgresql.org>
References: <E1p0Kx0-001QLw-17@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox