pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Reject missing database name in pg_regress and cohorts.
6+ messages / 1 participants
[nested] [flat]

* pgsql: Reject missing database name in pg_regress and cohorts.
@ 2022-11-30 18:01 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-11-30 18:01 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject missing database name in pg_regress and cohorts.

Writing "pg_regress --dbname= ..." led to a crash, because
we weren't expecting there to be no database name supplied.
It doesn't seem like a great idea to run regression tests
in whatever is the user's default database; so rather than
supporting this case let's explicitly reject it.

Per report from Xing Guo.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/CACpMh+A8cRvtvtOWVAZsCM1DU81GK4DL26R83y6ugZ1osV=ifA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d5515ca7cf1b095fab65c93710c71fece5baf67e

Modified Files
--------------
src/test/regress/pg_regress.c | 11 +++++++++++
1 file changed, 11 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Reject missing database name in pg_regress and cohorts.
@ 2022-11-30 18:01 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-11-30 18:01 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject missing database name in pg_regress and cohorts.

Writing "pg_regress --dbname= ..." led to a crash, because
we weren't expecting there to be no database name supplied.
It doesn't seem like a great idea to run regression tests
in whatever is the user's default database; so rather than
supporting this case let's explicitly reject it.

Per report from Xing Guo.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/CACpMh+A8cRvtvtOWVAZsCM1DU81GK4DL26R83y6ugZ1osV=ifA@mail.gmail.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f2f9e11d35226ff8d4cbb737b7c31d072e212178

Modified Files
--------------
src/test/regress/pg_regress.c | 11 +++++++++++
1 file changed, 11 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Reject missing database name in pg_regress and cohorts.
@ 2022-11-30 18:01 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-11-30 18:01 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject missing database name in pg_regress and cohorts.

Writing "pg_regress --dbname= ..." led to a crash, because
we weren't expecting there to be no database name supplied.
It doesn't seem like a great idea to run regression tests
in whatever is the user's default database; so rather than
supporting this case let's explicitly reject it.

Per report from Xing Guo.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/CACpMh+A8cRvtvtOWVAZsCM1DU81GK4DL26R83y6ugZ1osV=ifA@mail.gmail.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a949b7320fdfad445453375a1630f81f6bd3b49d

Modified Files
--------------
src/test/regress/pg_regress.c | 11 +++++++++++
1 file changed, 11 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Reject missing database name in pg_regress and cohorts.
@ 2022-11-30 18:01 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-11-30 18:01 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject missing database name in pg_regress and cohorts.

Writing "pg_regress --dbname= ..." led to a crash, because
we weren't expecting there to be no database name supplied.
It doesn't seem like a great idea to run regression tests
in whatever is the user's default database; so rather than
supporting this case let's explicitly reject it.

Per report from Xing Guo.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/CACpMh+A8cRvtvtOWVAZsCM1DU81GK4DL26R83y6ugZ1osV=ifA@mail.gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ae9939020dda40af579678489b11ef20fe3cca05

Modified Files
--------------
src/test/regress/pg_regress.c | 11 +++++++++++
1 file changed, 11 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Reject missing database name in pg_regress and cohorts.
@ 2022-11-30 18:01 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-11-30 18:01 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject missing database name in pg_regress and cohorts.

Writing "pg_regress --dbname= ..." led to a crash, because
we weren't expecting there to be no database name supplied.
It doesn't seem like a great idea to run regression tests
in whatever is the user's default database; so rather than
supporting this case let's explicitly reject it.

Per report from Xing Guo.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/CACpMh+A8cRvtvtOWVAZsCM1DU81GK4DL26R83y6ugZ1osV=ifA@mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a587901786d5c1bfdff47f8de4e346dbd2746cc9

Modified Files
--------------
src/test/regress/pg_regress.c | 11 +++++++++++
1 file changed, 11 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Reject missing database name in pg_regress and cohorts.
@ 2022-11-30 18:01 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-11-30 18:01 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject missing database name in pg_regress and cohorts.

Writing "pg_regress --dbname= ..." led to a crash, because
we weren't expecting there to be no database name supplied.
It doesn't seem like a great idea to run regression tests
in whatever is the user's default database; so rather than
supporting this case let's explicitly reject it.

Per report from Xing Guo.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/CACpMh+A8cRvtvtOWVAZsCM1DU81GK4DL26R83y6ugZ1osV=ifA@mail.gmail.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/04f3acc97e426c5df1e31cd51b86fc1a93ca77dc

Modified Files
--------------
src/test/regress/pg_regress.c | 11 +++++++++++
1 file changed, 11 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2022-11-30 18:01 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-11-30 18:01 pgsql: Reject missing database name in pg_regress and cohorts. Tom Lane <tgl@sss.pgh.pa.us>
2022-11-30 18:01 pgsql: Reject missing database name in pg_regress and cohorts. Tom Lane <tgl@sss.pgh.pa.us>
2022-11-30 18:01 pgsql: Reject missing database name in pg_regress and cohorts. Tom Lane <tgl@sss.pgh.pa.us>
2022-11-30 18:01 pgsql: Reject missing database name in pg_regress and cohorts. Tom Lane <tgl@sss.pgh.pa.us>
2022-11-30 18:01 pgsql: Reject missing database name in pg_regress and cohorts. Tom Lane <tgl@sss.pgh.pa.us>
2022-11-30 18:01 pgsql: Reject missing database name in pg_regress and cohorts. Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox