pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Reject missing database name in pg_regress and cohorts.
Date: Wed, 30 Nov 2022 18:01:53 +0000
Message-ID: <E1p0RP6-001Sbe-KE@gemulon.postgresql.org> (raw)

Reject missing database name in pg_regress and cohorts.

Writing "pg_regress --dbname= ..." led to a crash, because
we weren't expecting there to be no database name supplied.
It doesn't seem like a great idea to run regression tests
in whatever is the user's default database; so rather than
supporting this case let's explicitly reject it.

Per report from Xing Guo.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/CACpMh+A8cRvtvtOWVAZsCM1DU81GK4DL26R83y6ugZ1osV=ifA@mail.gmail.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/04f3acc97e426c5df1e31cd51b86fc1a93ca77dc

Modified Files
--------------
src/test/regress/pg_regress.c | 11 +++++++++++
1 file changed, 11 insertions(+)



view thread (6+ messages)  latest in thread

Message-ID: <E1p0RP6-001Sbe-KE@gemulon.postgresql.org>
Permalink:  ../E1p0RP6-001Sbe-KE@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1p0RP6-001Sbe-KE@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Reject missing database name in pg_regress and cohorts.
  In-Reply-To: <E1p0RP6-001Sbe-KE@gemulon.postgresql.org>
  References: <E1p0RP6-001Sbe-KE@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox