pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix under-parenthesized display of AT TIME ZONE constructs.
Date: Thu, 01 Dec 2022 16:38:26 +0000
Message-ID: <E1p0mZt-001aWb-PH@gemulon.postgresql.org> (raw)

Fix under-parenthesized display of AT TIME ZONE constructs.

In commit 40c24bfef, I forgot to use get_rule_expr_paren() for the
arguments of AT TIME ZONE, resulting in possibly not printing parens
for expressions that need it.  But get_rule_expr_paren() wouldn't have
gotten it right anyway, because isSimpleNode() hadn't been taught that
COERCE_SQL_SYNTAX parent nodes don't guarantee sufficient parentheses.
Improve all that.  Also use this methodology for F_IS_NORMALIZED, so
that we don't print useless parens for that.

In passing, remove a comment that was obsoleted later.

Per report from Duncan Sands.  Back-patch to v14 where this code
came in.  (Before that, we didn't try to print AT TIME ZONE that way,
so there was no bug just ugliness.)

Discussion: https://postgr.es/m/f41566aa-a057-6628-4b7c-b48770ecb84a@deepbluecap.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1dd6700f44d2e14616d464a5f490552b7036ad3f

Modified Files
--------------
src/backend/utils/adt/ruleutils.c         | 28 ++++++++++++++--------------
src/test/regress/expected/create_view.out |  8 +++++---
src/test/regress/sql/create_view.sql      |  1 +
3 files changed, 20 insertions(+), 17 deletions(-)



view thread (3+ messages)

Message-ID: <E1p0mZt-001aWb-PH@gemulon.postgresql.org>
Permalink:  ../E1p0mZt-001aWb-PH@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1p0mZt-001aWb-PH@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix under-parenthesized display of AT TIME ZONE constructs.
  In-Reply-To: <E1p0mZt-001aWb-PH@gemulon.postgresql.org>
  References: <E1p0mZt-001aWb-PH@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox