pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix Memoize to work with partitionwise joining.
Date: Mon, 05 Dec 2022 17:36:47 +0000
Message-ID: <E1p2FOY-0027w2-Vt@gemulon.postgresql.org> (raw)

Fix Memoize to work with partitionwise joining.

A couple of places weren't up to speed for this.  By sheer good
luck, we didn't fail but just selected a non-memoized join plan,
at least in the test case we have.  Nonetheless, it's a bug,
and I'm not quite sure that it couldn't have worse consequences
in other examples.  So back-patch to v14 where Memoize came in.

Richard Guo

Discussion: https://postgr.es/m/CAMbWs48GkNom272sfp0-WeD6_0HSR19BJ4H1c9ZKSfbVnJsvRg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d69d01ba9d8d774487032459ebb83d2086715f01

Modified Files
--------------
src/backend/optimizer/path/joinpath.c |  3 ++-
src/backend/optimizer/util/pathnode.c |  1 +
src/include/nodes/pathnodes.h         |  4 ++--
src/test/regress/expected/memoize.out | 39 +++++++++++++++++++++++++++++++++++
src/test/regress/sql/memoize.sql      | 19 +++++++++++++++++
5 files changed, 63 insertions(+), 3 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1p2FOY-0027w2-Vt@gemulon.postgresql.org>
Permalink:  ../E1p2FOY-0027w2-Vt@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1p2FOY-0027w2-Vt@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix Memoize to work with partitionwise joining.
  In-Reply-To: <E1p2FOY-0027w2-Vt@gemulon.postgresql.org>
  References: <E1p2FOY-0027w2-Vt@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox