pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix Memoize to work with partitionwise joining. 3+ messages / 1 participants [nested] [flat]
* pgsql: Fix Memoize to work with partitionwise joining. @ 2022-12-05 17:36 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2022-12-05 17:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix Memoize to work with partitionwise joining. A couple of places weren't up to speed for this. By sheer good luck, we didn't fail but just selected a non-memoized join plan, at least in the test case we have. Nonetheless, it's a bug, and I'm not quite sure that it couldn't have worse consequences in other examples. So back-patch to v14 where Memoize came in. Richard Guo Discussion: https://postgr.es/m/CAMbWs48GkNom272sfp0-WeD6_0HSR19BJ4H1c9ZKSfbVnJsvRg@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/d69d01ba9d8d774487032459ebb83d2086715f01 Modified Files -------------- src/backend/optimizer/path/joinpath.c | 3 ++- src/backend/optimizer/util/pathnode.c | 1 + src/include/nodes/pathnodes.h | 4 ++-- src/test/regress/expected/memoize.out | 39 +++++++++++++++++++++++++++++++++++ src/test/regress/sql/memoize.sql | 19 +++++++++++++++++ 5 files changed, 63 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix Memoize to work with partitionwise joining. @ 2022-12-05 17:36 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2022-12-05 17:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix Memoize to work with partitionwise joining. A couple of places weren't up to speed for this. By sheer good luck, we didn't fail but just selected a non-memoized join plan, at least in the test case we have. Nonetheless, it's a bug, and I'm not quite sure that it couldn't have worse consequences in other examples. So back-patch to v14 where Memoize came in. Richard Guo Discussion: https://postgr.es/m/CAMbWs48GkNom272sfp0-WeD6_0HSR19BJ4H1c9ZKSfbVnJsvRg@mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c959f84c2b770bc136ade3cfd11f6063a51d2708 Modified Files -------------- src/backend/optimizer/path/joinpath.c | 14 ++++++++++++- src/backend/optimizer/util/pathnode.c | 1 + src/include/nodes/pathnodes.h | 4 ++-- src/test/regress/expected/memoize.out | 39 +++++++++++++++++++++++++++++++++++ src/test/regress/sql/memoize.sql | 19 +++++++++++++++++ 5 files changed, 74 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix Memoize to work with partitionwise joining. @ 2022-12-05 17:36 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2022-12-05 17:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix Memoize to work with partitionwise joining. A couple of places weren't up to speed for this. By sheer good luck, we didn't fail but just selected a non-memoized join plan, at least in the test case we have. Nonetheless, it's a bug, and I'm not quite sure that it couldn't have worse consequences in other examples. So back-patch to v14 where Memoize came in. Richard Guo Discussion: https://postgr.es/m/CAMbWs48GkNom272sfp0-WeD6_0HSR19BJ4H1c9ZKSfbVnJsvRg@mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/dc3648f65bea3d3373b4e0026ae83bd8f436ee40 Modified Files -------------- src/backend/optimizer/path/joinpath.c | 14 ++++++++++++- src/backend/optimizer/util/pathnode.c | 1 + src/include/nodes/pathnodes.h | 4 ++-- src/test/regress/expected/memoize.out | 39 +++++++++++++++++++++++++++++++++++ src/test/regress/sql/memoize.sql | 19 +++++++++++++++++ 5 files changed, 74 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2022-12-05 17:36 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-12-05 17:36 pgsql: Fix Memoize to work with partitionwise joining. Tom Lane <tgl@sss.pgh.pa.us> 2022-12-05 17:36 pgsql: Fix Memoize to work with partitionwise joining. Tom Lane <tgl@sss.pgh.pa.us> 2022-12-05 17:36 pgsql: Fix Memoize to work with partitionwise joining. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox