pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Etsuro Fujita <efujita@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove new structure member from ResultRelInfo.
Date: Thu, 08 Dec 2022 07:26:48 +0000
Message-ID: <E1p3BIt-002TkK-5i@gemulon.postgresql.org> (raw)

Remove new structure member from ResultRelInfo.

In commit ffbb7e65a, I added a ModifyTableState member to ResultRelInfo
to save the owning ModifyTableState for use by nodeModifyTable.c when
performing batch inserts, but as pointed out by Tom Lane, that changed
the array stride of es_result_relations, and that would break any
previously-compiled extension code that accesses that array.  Fix by
removing that member from ResultRelInfo and instead adding a List member
at the end of EState to save such ModifyTableStates.

Per report from Tom Lane.  Back-patch to v14, like the previous commit;
I chose to apply the patch to HEAD as well, to make back-patching easy.

Discussion: http://postgr.es/m/4065383.1669395453%40sss.pgh.pa.us

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a0bf7a0eccbf73c7ce4efd7b09c3c9544a57c5a4

Modified Files
--------------
src/backend/executor/execMain.c        |  1 -
src/backend/executor/execPartition.c   |  7 -------
src/backend/executor/execUtils.c       |  4 +++-
src/backend/executor/nodeModifyTable.c | 31 ++++++++++++++++---------------
src/include/nodes/execnodes.h          |  8 +++-----
5 files changed, 22 insertions(+), 29 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1p3BIt-002TkK-5i@gemulon.postgresql.org>
Permalink:  ../E1p3BIt-002TkK-5i@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1p3BIt-002TkK-5i@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: efujita@postgresql.org
  Subject: Re: pgsql: Remove new structure member from ResultRelInfo.
  In-Reply-To: <E1p3BIt-002TkK-5i@gemulon.postgresql.org>
  References: <E1p3BIt-002TkK-5i@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox