pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Remove new structure member from ResultRelInfo. 3+ messages / 1 participants [nested] [flat]
* pgsql: Remove new structure member from ResultRelInfo. @ 2022-12-08 07:26 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Etsuro Fujita @ 2022-12-08 07:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove new structure member from ResultRelInfo. In commit ffbb7e65a, I added a ModifyTableState member to ResultRelInfo to save the owning ModifyTableState for use by nodeModifyTable.c when performing batch inserts, but as pointed out by Tom Lane, that changed the array stride of es_result_relations, and that would break any previously-compiled extension code that accesses that array. Fix by removing that member from ResultRelInfo and instead adding a List member at the end of EState to save such ModifyTableStates. Per report from Tom Lane. Back-patch to v14, like the previous commit; I chose to apply the patch to HEAD as well, to make back-patching easy. Discussion: http://postgr.es/m/4065383.1669395453%40sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4b3e37993254ed098219e62ceffb1b32fac388cb Modified Files -------------- src/backend/executor/execMain.c | 1 - src/backend/executor/execPartition.c | 7 ------- src/backend/executor/execUtils.c | 4 +++- src/backend/executor/nodeModifyTable.c | 31 ++++++++++++++++--------------- src/include/nodes/execnodes.h | 8 +++----- 5 files changed, 22 insertions(+), 29 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Remove new structure member from ResultRelInfo. @ 2022-12-08 07:26 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Etsuro Fujita @ 2022-12-08 07:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove new structure member from ResultRelInfo. In commit ffbb7e65a, I added a ModifyTableState member to ResultRelInfo to save the owning ModifyTableState for use by nodeModifyTable.c when performing batch inserts, but as pointed out by Tom Lane, that changed the array stride of es_result_relations, and that would break any previously-compiled extension code that accesses that array. Fix by removing that member from ResultRelInfo and instead adding a List member at the end of EState to save such ModifyTableStates. Per report from Tom Lane. Back-patch to v14, like the previous commit; I chose to apply the patch to HEAD as well, to make back-patching easy. Discussion: http://postgr.es/m/4065383.1669395453%40sss.pgh.pa.us Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a0bf7a0eccbf73c7ce4efd7b09c3c9544a57c5a4 Modified Files -------------- src/backend/executor/execMain.c | 1 - src/backend/executor/execPartition.c | 7 ------- src/backend/executor/execUtils.c | 4 +++- src/backend/executor/nodeModifyTable.c | 31 ++++++++++++++++--------------- src/include/nodes/execnodes.h | 8 +++----- 5 files changed, 22 insertions(+), 29 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Remove new structure member from ResultRelInfo. @ 2022-12-08 07:26 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Etsuro Fujita @ 2022-12-08 07:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove new structure member from ResultRelInfo. In commit ffbb7e65a, I added a ModifyTableState member to ResultRelInfo to save the owning ModifyTableState for use by nodeModifyTable.c when performing batch inserts, but as pointed out by Tom Lane, that changed the array stride of es_result_relations, and that would break any previously-compiled extension code that accesses that array. Fix by removing that member from ResultRelInfo and instead adding a List member at the end of EState to save such ModifyTableStates. Per report from Tom Lane. Back-patch to v14, like the previous commit; I chose to apply the patch to HEAD as well, to make back-patching easy. Discussion: http://postgr.es/m/4065383.1669395453%40sss.pgh.pa.us Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d43a97ef493a7edc9e03b5dd15870e04a0c38f75 Modified Files -------------- src/backend/executor/execMain.c | 1 - src/backend/executor/execPartition.c | 7 ------- src/backend/executor/execUtils.c | 4 +++- src/backend/executor/nodeModifyTable.c | 31 ++++++++++++++++--------------- src/include/nodes/execnodes.h | 8 +++----- 5 files changed, 22 insertions(+), 29 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2022-12-08 07:26 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-12-08 07:26 pgsql: Remove new structure member from ResultRelInfo. Etsuro Fujita <efujita@postgresql.org> 2022-12-08 07:26 pgsql: Remove new structure member from ResultRelInfo. Etsuro Fujita <efujita@postgresql.org> 2022-12-08 07:26 pgsql: Remove new structure member from ResultRelInfo. Etsuro Fujita <efujita@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox