pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Update types in File API
Date: Thu, 08 Dec 2022 08:06:13 +0000
Message-ID: <E1p3Bv2-002U6Z-RE@gemulon.postgresql.org> (raw)

Update types in File API

Make the argument types of the File API match stdio better:

- Change the data buffer to void *, from char *.
- Change FileWrite() data buffer to const on top of that.
- Change amounts to size_t, from int.

In passing, change the FilePrefetch() amount argument from int to
off_t, to match the underlying posix_fadvise().

Discussion: https://www.postgresql.org/message-id/flat/11dda853-bb5b-59ba-a746-e168b1ce4bdb%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2d4f1ba6cfc2f0a977f1c30bda9848041343e248

Modified Files
--------------
src/backend/storage/file/fd.c | 8 ++++----
src/include/storage/fd.h      | 6 +++---
2 files changed, 7 insertions(+), 7 deletions(-)



Message-ID: <E1p3Bv2-002U6Z-RE@gemulon.postgresql.org>
Permalink:  ../E1p3Bv2-002U6Z-RE@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1p3Bv2-002U6Z-RE@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org
  Subject: Re: pgsql: Update types in File API
  In-Reply-To: <E1p3Bv2-002U6Z-RE@gemulon.postgresql.org>
  References: <E1p3Bv2-002U6Z-RE@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox