pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Restructure soft-error handling in formatting.c.
Date: Sat, 10 Dec 2022 01:16:10 +0000
Message-ID: <E1p3oTJ-002kSo-QW@gemulon.postgresql.org> (raw)

Restructure soft-error handling in formatting.c.

Replace the error trapping scheme introduced in 5bc450629 with our
shiny new errsave/ereturn mechanism.  This doesn't have any real
functional impact (although I think that the new coding is able
to report a few more errors softly than v15 did).  And I doubt
there's any measurable performance difference either.  But this
gets rid of an ad-hoc, one-of-a-kind design in favor of a mechanism
that will be widely used going forward, so it should be a net win
for code readability.

Discussion: https://postgr.es/m/3bbbb0df-7382-bf87-9737-340ba096e034@postgrespro.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4dd687502d9eb0b2984c36579c2fcf5283adfa7c

Modified Files
--------------
src/backend/utils/adt/formatting.c    | 666 ++++++++++++++++------------------
src/backend/utils/adt/jsonpath_exec.c |  12 +-
src/include/utils/formatting.h        |   2 +-
3 files changed, 322 insertions(+), 358 deletions(-)



Message-ID: <E1p3oTJ-002kSo-QW@gemulon.postgresql.org>
Permalink:  ../E1p3oTJ-002kSo-QW@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1p3oTJ-002kSo-QW@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Restructure soft-error handling in formatting.c.
  In-Reply-To: <E1p3oTJ-002kSo-QW@gemulon.postgresql.org>
  References: <E1p3oTJ-002kSo-QW@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox