pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add subquery pullup handling for WindowClause runCondition
Date: Sat, 10 Dec 2022 06:27:44 +0000
Message-ID: <E1p3tKp-002n5K-32@gemulon.postgresql.org> (raw)

Add subquery pullup handling for WindowClause runCondition

9d9c02ccd added code to allow WindowAgg to take some shortcuts when a
monotonic WindowFunc reached some value that it could never come back
from due to the function's monotonic nature.  That commit added a
runCondition field to WindowClause to store the condition which, when it
becomes false we can start taking shortcuts in nodeWindowAgg.c.

Here we fix an issue where subquery pullups didn't properly update the
runCondition to update the Vars to properly reference the new query level.

Here we also add a missing call to preprocess_expression() for the
WindowClause's runCondtion.  The WindowFuncs in the targetlist will have
had this process done, so we must also do it for the WindowFuncs in the
runCondition so that they can be correctly found in the targetlist
during setrefs.c

Bug: #17709
Reported-by: Alexey Makhmutov
Author: Richard Guo, David Rowley
Discussion: https://postgr.es/m/17709-4f557160e3e8ee9a@postgresql.org
Backpatch-through: 15, where 9d9c02ccd was introduced

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/94985c21020aa4a40d0dda1a26ac3e35a57e4681

Modified Files
--------------
src/backend/optimizer/plan/planner.c      | 3 +++
src/backend/optimizer/prep/prepjointree.c | 9 +++++++++
2 files changed, 12 insertions(+)



view thread (2+ messages)  latest in thread

Message-ID: <E1p3tKp-002n5K-32@gemulon.postgresql.org>
Permalink:  ../E1p3tKp-002n5K-32@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1p3tKp-002n5K-32@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org
  Subject: Re: pgsql: Add subquery pullup handling for WindowClause runCondition
  In-Reply-To: <E1p3tKp-002n5K-32@gemulon.postgresql.org>
  References: <E1p3tKp-002n5K-32@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox