pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Use the macro, not handwritten code, to construct anymultirange_
Date: Sat, 10 Dec 2022 22:23:00 +0000
Message-ID: <E1p48FH-002uQU-UG@gemulon.postgresql.org> (raw)

Use the macro, not handwritten code, to construct anymultirange_in().

Apparently anymultirange_in was written before we converted all
these pseudotype input functions to use a common macro, and it didn't
get fixed before committing.  Sloppy merging probably explains its
unintuitive ordering, too, so rearrange.

Noted while surveying datatype input functions to see what we
have left to fix.  I'm inclined to leave the pseudotypes as
throwing hard errors, because it's difficult to see a reason why
anyone would need something else.  But in any case, if we want
to change that, we shouldn't have to change multiple copies of
the code.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e730718072bdc8379f3d099c64455c20d6a6d1ad

Modified Files
--------------
src/backend/utils/adt/pseudotypes.c | 27 ++++++++-------------------
1 file changed, 8 insertions(+), 19 deletions(-)



Message-ID: <E1p48FH-002uQU-UG@gemulon.postgresql.org>
Permalink:  ../E1p48FH-002uQU-UG@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1p48FH-002uQU-UG@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Use the macro, not handwritten code, to construct anymultirange_
  In-Reply-To: <E1p48FH-002uQU-UG@gemulon.postgresql.org>
  References: <E1p48FH-002uQU-UG@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox