pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Standardize error reports in unimplemented I/O functions.
Date: Sat, 10 Dec 2022 23:26:54 +0000
Message-ID: <E1p49F7-002uwE-OR@gemulon.postgresql.org> (raw)

Standardize error reports in unimplemented I/O functions.

We chose a specific wording of the not-implemented errors for
pseudotype I/O functions and other cases where there's little
value in implementing input and/or output.  gtsvectorin never
got that memo though, nor did most of contrib.  Make these all
fall in line, mostly because I'm a neatnik but also to remove
unnecessary translatable strings.

gbtreekey_in needs a bit of extra love since it supports
multiple SQL types.  Sadly, gbtreekey_out doesn't have the
ability to do that, but I think it's unreachable anyway.

Noted while surveying datatype input functions to see what we
have left to fix.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d02ef65bce6575e10ac0b4e7b8552ff67687c944

Modified Files
--------------
contrib/btree_gist/btree_gist.c   | 18 +++++++++++-------
contrib/hstore/hstore_gist.c      | 14 ++++++++++----
contrib/intarray/_intbig_gist.c   | 10 ++++++----
contrib/ltree/ltree_gist.c        | 10 ++++++----
contrib/pg_trgm/trgm_gist.c       | 14 ++++++++++----
src/backend/utils/adt/tsgistidx.c |  6 ++++--
6 files changed, 47 insertions(+), 25 deletions(-)



Message-ID: <E1p49F7-002uwE-OR@gemulon.postgresql.org>
Permalink:  ../E1p49F7-002uwE-OR@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1p49F7-002uwE-OR@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Standardize error reports in unimplemented I/O functions.
  In-Reply-To: <E1p49F7-002uwE-OR@gemulon.postgresql.org>
  References: <E1p49F7-002uwE-OR@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox