From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Get rid of recursion-marker values in enum AlterTableType
Date: Mon, 12 Dec 2022 14:11:25 +0000
Message-ID: <E1p4jWe-003DSw-8H@gemulon.postgresql.org> (raw)
Get rid of recursion-marker values in enum AlterTableType
During ALTER TABLE execution, when prep-time handling of subcommands of
certain types determine that execution-time handling requires recursion,
they signal this by changing the subcommand type to a special value.
This can be done in a simpler way by using a separate flag introduced by
commit ec0925c22a3d, so do that.
Catversion bumped. It's not clear to me that ALTER TABLE subcommands
are stored anywhere in catalogs (CREATE FUNCTION rejects it in BEGIN
ATOMIC function bodies), but we do have both write and read support for
them, so be safe.
Discussion: https://postgr.es/m/20220929090033.zxuaezcdwh2fgfjb@alvherre.pgsql
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/840ff5f451cd9a391d237fc60894fea7ad82a189
Modified Files
--------------
src/backend/commands/tablecmds.c | 67 +++++-----------------
src/backend/parser/parse_utilcmd.c | 2 -
src/include/catalog/catversion.h | 2 +-
src/include/nodes/parsenodes.h | 5 --
.../modules/test_ddl_deparse/test_ddl_deparse.c | 20 ++-----
5 files changed, 18 insertions(+), 78 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org
Subject: Re: pgsql: Get rid of recursion-marker values in enum AlterTableType
In-Reply-To: <E1p4jWe-003DSw-8H@gemulon.postgresql.org>
References: <E1p4jWe-003DSw-8H@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox