pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Order getopt arguments
Date: Mon, 12 Dec 2022 14:22:16 +0000
Message-ID: <E1p4jh9-003DYJ-Dh@gemulon.postgresql.org> (raw)

Order getopt arguments

Order the letters in the arguments of getopt() and getopt_long(), as
well as in the subsequent switch statements.  In most cases, I used
alphabetical with lower case first.  In a few cases, existing
different orders (e.g., upper case first) was kept to reduce the diff
size.

Discussion: https://www.postgresql.org/message-id/flat/3efd0fe8-351b-f836-9122-886002602357%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/df8b8968d4095f44acd6de03b4add65f9709b79d

Modified Files
--------------
src/backend/bootstrap/bootstrap.c                |  52 +++---
src/backend/postmaster/postmaster.c              |  56 +++---
src/backend/tcop/postgres.c                      |  54 +++---
src/bin/pg_amcheck/pg_amcheck.c                  |  10 +-
src/bin/pg_archivecleanup/pg_archivecleanup.c    |   2 +-
src/bin/pg_basebackup/pg_basebackup.c            | 108 ++++++------
src/bin/pg_basebackup/pg_receivewal.c            |  41 +++--
src/bin/pg_basebackup/pg_recvlogical.c           |   8 +-
src/bin/pg_checksums/pg_checksums.c              |  14 +-
src/bin/pg_upgrade/option.c                      |   2 +-
src/bin/pgbench/pgbench.c                        | 206 +++++++++++------------
src/bin/scripts/clusterdb.c                      |  38 ++---
src/bin/scripts/createdb.c                       |  44 ++---
src/bin/scripts/dropdb.c                         |  20 +--
src/bin/scripts/dropuser.c                       |  14 +-
src/bin/scripts/reindexdb.c                      |  56 +++---
src/bin/scripts/vacuumdb.c                       |  98 +++++------
src/interfaces/ecpg/preproc/ecpg.c               |  91 +++++-----
src/test/modules/libpq_pipeline/libpq_pipeline.c |   8 +-
19 files changed, 458 insertions(+), 464 deletions(-)



Message-ID: <E1p4jh9-003DYJ-Dh@gemulon.postgresql.org>
Permalink:  ../E1p4jh9-003DYJ-Dh@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1p4jh9-003DYJ-Dh@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org
  Subject: Re: pgsql: Order getopt arguments
  In-Reply-To: <E1p4jh9-003DYJ-Dh@gemulon.postgresql.org>
  References: <E1p4jh9-003DYJ-Dh@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox