pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Refactor ExecGrant_*() functions
Date: Tue, 13 Dec 2022 06:53:12 +0000
Message-ID: <E1p4zA7-003L3t-P1@gemulon.postgresql.org> (raw)

Refactor ExecGrant_*() functions

Instead of half a dozen of mostly-duplicate ExecGrant_Foo() functions,
write one common function ExecGrant_generic() that can handle most of
them.  We already have all the information we need, such as which
system catalog corresponds to which catalog table and which column is
the ACL column.

Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Antonin Houska <ah@cybertec.at>
Discussion: https://www.postgresql.org/message-id/flat/22c7e802-4e7d-8d87-8b71-cba95e6f4bcf%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/369f09e420efe27359b06b69c0265f4aec5c2134

Modified Files
--------------
src/backend/catalog/aclchk.c | 1050 +++++-------------------------------------
1 file changed, 124 insertions(+), 926 deletions(-)



Message-ID: <E1p4zA7-003L3t-P1@gemulon.postgresql.org>
Permalink:  ../E1p4zA7-003L3t-P1@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1p4zA7-003L3t-P1@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org
  Subject: Re: pgsql: Refactor ExecGrant_*() functions
  In-Reply-To: <E1p4zA7-003L3t-P1@gemulon.postgresql.org>
  References: <E1p4zA7-003L3t-P1@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox