From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Convert a few more datatype input functions to report errors sof
Date: Wed, 14 Dec 2022 22:50:34 +0000
Message-ID: <E1p5aa9-003c1K-WD@gemulon.postgresql.org> (raw)
Convert a few more datatype input functions to report errors softly.
Convert assorted internal-ish datatypes, namely aclitemin,
int2vectorin, oidin, oidvectorin, pg_lsn_in, pg_snapshot_in,
and tidin to the new style.
(Some others you might expect to find in this group, such as
cidin and xidin, need no changes because they never throw
errors at all. That seems a little cheesy ... but it is not in
the charter of this patch series to add new error conditions.)
Amul Sul, minor mods by me
Discussion: https://postgr.es/m/CAAJ_b97KeDWUdpTKGOaFYPv0OicjOu6EW+QYWj-Ywrgj_aEy1g@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/47f3f97fcdee28e3eb70cd2ebfd7b4899570b018
Modified Files
--------------
src/backend/utils/adt/acl.c | 62 +++++++++++++++++++++++---------
src/backend/utils/adt/int.c | 9 ++---
src/backend/utils/adt/oid.c | 37 +++++++++++++------
src/backend/utils/adt/pg_lsn.c | 2 +-
src/backend/utils/adt/tid.c | 9 ++---
src/backend/utils/adt/xid8funcs.c | 7 ++--
src/test/regress/expected/int2.out | 19 ++++++++++
src/test/regress/expected/oid.out | 62 ++++++++++++++++++++++++++++++++
src/test/regress/expected/pg_lsn.out | 13 +++++++
src/test/regress/expected/privileges.out | 43 ++++++++++++++++++++++
src/test/regress/expected/tid.out | 25 +++++++++++++
src/test/regress/expected/xid.out | 31 ++++++++++++++++
src/test/regress/sql/int2.sql | 5 +++
src/test/regress/sql/oid.sql | 14 ++++++++
src/test/regress/sql/pg_lsn.sql | 4 +++
src/test/regress/sql/privileges.sql | 9 +++++
src/test/regress/sql/tid.sql | 6 ++++
src/test/regress/sql/xid.sql | 7 ++++
18 files changed, 323 insertions(+), 41 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Convert a few more datatype input functions to report errors sof
In-Reply-To: <E1p5aa9-003c1K-WD@gemulon.postgresql.org>
References: <E1p5aa9-003c1K-WD@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox