pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Switch some system functions to use get_call_result_type()
Date: Wed, 21 Dec 2022 01:12:57 +0000
Message-ID: <E1p7nfE-004dLv-D3@gemulon.postgresql.org> (raw)

Switch some system functions to use get_call_result_type()

This shaves some code by replacing the combinations of
CreateTemplateTupleDesc()/TupleDescInitEntry() hardcoding a mapping of
the attributes listed in pg_proc.dat by get_call_result_type() to build
the TupleDesc needed for the rows generated.

get_call_result_type() is more expensive than the former style, but this
removes some duplication with the lists of OUT parameters (pg_proc.dat
and the attributes hardcoded in these code paths).  This is applied to
functions that are not considered as critical (aka that could be called
repeatedly for monitoring purposes).

Author: Bharath Rupireddy
Reviewed-by: Robert Haas, Álvaro Herrera, Tom Lane, Michael Paquier
Discussion: https://postgr.es/m/CALj2ACV23HW5HP5hFjd89FNS-z5X8r2jNXdMXcpN2BgTtKd87w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/22e3b558052aa209cba2a8fec192d76b5faef19e

Modified Files
--------------
contrib/old_snapshot/time_mapping.c     |  26 ++------
contrib/pg_visibility/pg_visibility.c   |   6 +-
src/backend/access/transam/commit_ts.c  |  26 ++------
src/backend/access/transam/multixact.c  |   9 +--
src/backend/catalog/objectaddress.c     |  42 ++-----------
src/backend/commands/sequence.c         |  19 +-----
src/backend/tsearch/wparser.c           |  35 +++++------
src/backend/utils/adt/datetime.c        |  17 ++---
src/backend/utils/adt/misc.c            |  31 ++-------
src/backend/utils/adt/partitionfuncs.c  |  14 +----
src/backend/utils/adt/tsvector_op.c     |  15 ++---
src/backend/utils/misc/pg_controldata.c | 108 +++-----------------------------
12 files changed, 62 insertions(+), 286 deletions(-)



Message-ID: <E1p7nfE-004dLv-D3@gemulon.postgresql.org>
Permalink:  ../E1p7nfE-004dLv-D3@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1p7nfE-004dLv-D3@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Switch some system functions to use get_call_result_type()
  In-Reply-To: <E1p7nfE-004dLv-D3@gemulon.postgresql.org>
  References: <E1p7nfE-004dLv-D3@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox