pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Use scanned_pages to decide when to failsafe check.
Date: Thu, 22 Dec 2022 18:43:42 +0000
Message-ID: <E1p8QXd-004ucD-EM@gemulon.postgresql.org> (raw)

Use scanned_pages to decide when to failsafe check.

Perform a failsafe check every time VACUUM's first heap scan scans a
further FAILSAFE_EVERY_PAGES pages, rather than using an approach based
on the number of physical blocks that our current blkno is from the
blkno at the time of the previous failsafe check.  That way VACUUM will
perform a failsafe check every time it has scanned a uniform number of
pages, without it mattering when or how VACUUM skipped pages using the
visibility map.

Sami Imseih, with changes to FAILSAFE_EVERY_PAGES comments added by me.

Author: Sami Imseih <simseih@amazon.com>
Reviewed-By: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/401CE010-4049-4B94-9961-0B610A5D254D%40amazon.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/07eef53955ea9885dd3e4701b7eaa34ccdf2ae02

Modified Files
--------------
src/backend/access/heap/vacuumlazy.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)



Message-ID: <E1p8QXd-004ucD-EM@gemulon.postgresql.org>
Permalink:  ../E1p8QXd-004ucD-EM@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1p8QXd-004ucD-EM@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: pg@bowt.ie
  Subject: Re: pgsql: Use scanned_pages to decide when to failsafe check.
  In-Reply-To: <E1p8QXd-004ucD-EM@gemulon.postgresql.org>
  References: <E1p8QXd-004ucD-EM@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox