pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix some incorrectness in upgrade_adapt.sql on query for WITH OI 5+ messages / 1 participants [nested] [flat]
* pgsql: Fix some incorrectness in upgrade_adapt.sql on query for WITH OI @ 2022-12-23 02:28 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 5+ messages in thread From: Michael Paquier @ 2022-12-23 02:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix some incorrectness in upgrade_adapt.sql on query for WITH OIDS The query used to disable WITH OIDS in all the relations making use of it was checking for materialized views, but this is not a supported operation. On the contrary, this needs to be done on foreign tables. While on it, use quote_ident() in the ALTER TABLE strings built on the relation name. Author: Anton A. Melnikov, Michael Paquier Discussion: https://postgr.es/m/49f389ba-95ce-8a9b-09ae-f60650c0e7c7@inbox.ru Backpatch-through: 12 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/3022cb14339656be2afeee72150dcc5725838398 Modified Files -------------- src/bin/pg_upgrade/upgrade_adapt.sql | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix some incorrectness in upgrade_adapt.sql on query for WITH OI @ 2022-12-23 02:28 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 5+ messages in thread From: Michael Paquier @ 2022-12-23 02:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix some incorrectness in upgrade_adapt.sql on query for WITH OIDS The query used to disable WITH OIDS in all the relations making use of it was checking for materialized views, but this is not a supported operation. On the contrary, this needs to be done on foreign tables. While on it, use quote_ident() in the ALTER TABLE strings built on the relation name. Author: Anton A. Melnikov, Michael Paquier Discussion: https://postgr.es/m/49f389ba-95ce-8a9b-09ae-f60650c0e7c7@inbox.ru Backpatch-through: 12 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9c48a0f00011c45d9a7b8903ffbecd286cf46de0 Modified Files -------------- src/bin/pg_upgrade/upgrade_adapt.sql | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix some incorrectness in upgrade_adapt.sql on query for WITH OI @ 2022-12-23 02:28 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 5+ messages in thread From: Michael Paquier @ 2022-12-23 02:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix some incorrectness in upgrade_adapt.sql on query for WITH OIDS The query used to disable WITH OIDS in all the relations making use of it was checking for materialized views, but this is not a supported operation. On the contrary, this needs to be done on foreign tables. While on it, use quote_ident() in the ALTER TABLE strings built on the relation name. Author: Anton A. Melnikov, Michael Paquier Discussion: https://postgr.es/m/49f389ba-95ce-8a9b-09ae-f60650c0e7c7@inbox.ru Backpatch-through: 12 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/fd36b82c5d74ed355660beae79925a9faa36a084 Modified Files -------------- src/bin/pg_upgrade/upgrade_adapt.sql | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix some incorrectness in upgrade_adapt.sql on query for WITH OI @ 2022-12-23 02:28 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 5+ messages in thread From: Michael Paquier @ 2022-12-23 02:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix some incorrectness in upgrade_adapt.sql on query for WITH OIDS The query used to disable WITH OIDS in all the relations making use of it was checking for materialized views, but this is not a supported operation. On the contrary, this needs to be done on foreign tables. While on it, use quote_ident() in the ALTER TABLE strings built on the relation name. Author: Anton A. Melnikov, Michael Paquier Discussion: https://postgr.es/m/49f389ba-95ce-8a9b-09ae-f60650c0e7c7@inbox.ru Backpatch-through: 12 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d4fea2e89d44a0132e86a1659cf79e8c3057bb57 Modified Files -------------- src/bin/pg_upgrade/upgrade_adapt.sql | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix some incorrectness in upgrade_adapt.sql on query for WITH OI @ 2022-12-23 02:28 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 5+ messages in thread From: Michael Paquier @ 2022-12-23 02:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix some incorrectness in upgrade_adapt.sql on query for WITH OIDS The query used to disable WITH OIDS in all the relations making use of it was checking for materialized views, but this is not a supported operation. On the contrary, this needs to be done on foreign tables. While on it, use quote_ident() in the ALTER TABLE strings built on the relation name. Author: Anton A. Melnikov, Michael Paquier Discussion: https://postgr.es/m/49f389ba-95ce-8a9b-09ae-f60650c0e7c7@inbox.ru Backpatch-through: 12 Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a2688c4e0329687ca5105b7647bbff6bbe33cca4 Modified Files -------------- src/bin/pg_upgrade/upgrade_adapt.sql | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2022-12-23 02:28 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-12-23 02:28 pgsql: Fix some incorrectness in upgrade_adapt.sql on query for WITH OI Michael Paquier <michael@paquier.xyz> 2022-12-23 02:28 pgsql: Fix some incorrectness in upgrade_adapt.sql on query for WITH OI Michael Paquier <michael@paquier.xyz> 2022-12-23 02:28 pgsql: Fix some incorrectness in upgrade_adapt.sql on query for WITH OI Michael Paquier <michael@paquier.xyz> 2022-12-23 02:28 pgsql: Fix some incorrectness in upgrade_adapt.sql on query for WITH OI Michael Paquier <michael@paquier.xyz> 2022-12-23 02:28 pgsql: Fix some incorrectness in upgrade_adapt.sql on query for WITH OI Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox