pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix some incorrectness in upgrade_adapt.sql on query for WITH OI
Date: Fri, 23 Dec 2022 02:28:17 +0000
Message-ID: <E1p8XnE-004y5A-RV@gemulon.postgresql.org> (raw)

Fix some incorrectness in upgrade_adapt.sql on query for WITH OIDS

The query used to disable WITH OIDS in all the relations making use of
it was checking for materialized views, but this is not a supported
operation.  On the contrary, this needs to be done on foreign tables.

While on it, use quote_ident() in the ALTER TABLE strings built on the
relation name.

Author: Anton A. Melnikov, Michael Paquier
Discussion: https://postgr.es/m/49f389ba-95ce-8a9b-09ae-f60650c0e7c7@inbox.ru
Backpatch-through: 12

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d4fea2e89d44a0132e86a1659cf79e8c3057bb57

Modified Files
--------------
src/bin/pg_upgrade/upgrade_adapt.sql | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



view thread (5+ messages)

Message-ID: <E1p8XnE-004y5A-RV@gemulon.postgresql.org>
Permalink:  ../E1p8XnE-004y5A-RV@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1p8XnE-004y5A-RV@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Fix some incorrectness in upgrade_adapt.sql on query for WITH OI
  In-Reply-To: <E1p8XnE-004y5A-RV@gemulon.postgresql.org>
  References: <E1p8XnE-004y5A-RV@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox