pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Update upgrade_adapt.sql to handle tables using aclitem as data
Date: Fri, 23 Dec 2022 02:37:21 +0000
Message-ID: <E1p8Xw0-004y9D-Li@gemulon.postgresql.org> (raw)

Update upgrade_adapt.sql to handle tables using aclitem as data type

The regression test suite includes a table called "tab_core_types" that
has one attribute based on the type "aclitem".  Keeping this attribute
as-is causes hard failures when running pg_upgrade with an origin on
~15.  This commit updates upgrade_adapt.sql to automatically detect the
tables with such attributes and switch them to text so as pg_upgrade
is able to go through its run.

This does not provide the same detection coverage as pg_upgrade, where
we are able to find out aclitems used in arrays, domains or even
composite types, but this is (I guess) enough for most things like an
instance that had installcheck run on before the upgrade with a dump
generated from it.

Note that the buildfarm code has taken the simplest approach of just
dropping "tab_core_types", so what we have here is more modular.

Author: Anton A. Melnikov
Discussion: https://postgr.es/m/49f389ba-95ce-8a9b-09ae-f60650c0e7c7@inbox.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f4f2f2b84a0bbf9edbfc4a8684040a941cd6d085

Modified Files
--------------
src/bin/pg_upgrade/upgrade_adapt.sql | 30 +++++++++++++++++++++++++++++-
1 file changed, 29 insertions(+), 1 deletion(-)



Message-ID: <E1p8Xw0-004y9D-Li@gemulon.postgresql.org>
Permalink:  ../E1p8Xw0-004y9D-Li@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1p8Xw0-004y9D-Li@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Update upgrade_adapt.sql to handle tables using aclitem as data
  In-Reply-To: <E1p8Xw0-004y9D-Li@gemulon.postgresql.org>
  References: <E1p8Xw0-004y9D-Li@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox