From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Switch query fixing aclitems in ~15 from O(N^2) to O(N) in upgra
Date: Sun, 25 Dec 2022 23:02:02 +0000
Message-ID: <E1p9a0I-000PbW-Dl@gemulon.postgresql.org> (raw)
Switch query fixing aclitems in ~15 from O(N^2) to O(N) in upgrade_adapt.sql
f4f2f2b was doing a sequential scan of pg_class before checking if a
relation had attributes dependent on aclitem as data typewhen building
the set of ALTER TABLE queries, but it would be costly on a regression
database.
While on it, make the query style more consistent with the rest.
Reported-by: Justin Pryzby
Discussion: https://postgr.es/m/20221223032724.GQ1153@telsasoft.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d3c0cc4447307a2ffbcff8274573b544294e583c
Modified Files
--------------
src/bin/pg_upgrade/upgrade_adapt.sql | 26 +++++++++++---------------
1 file changed, 11 insertions(+), 15 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz
Subject: Re: pgsql: Switch query fixing aclitems in ~15 from O(N^2) to O(N) in upgra
In-Reply-To: <E1p9a0I-000PbW-Dl@gemulon.postgresql.org>
References: <E1p9a0I-000PbW-Dl@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox