From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Simplify the implementations of the to_reg* functions.
Date: Tue, 27 Dec 2022 17:33:10 +0000
Message-ID: <E1pADp8-000h6b-7L@gemulon.postgresql.org> (raw)
Simplify the implementations of the to_reg* functions.
Given the soft-input-error feature, we can reduce these functions
to be just thin wrappers around a soft-error call of the
corresponding datatype input function. This means less code and
more certainty that the to_reg* functions match the normal input
behavior.
Notably, it also means that they will accept numeric OID input,
which they didn't before. It's not clear to me if that omission
had more than laziness behind it, but it doesn't seem like
something we need to work hard to preserve.
Discussion: https://postgr.es/m/3910031.1672095600@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3ea7329c9a79ade27b5d3742d1a41ce6d0d9aca8
Modified Files
--------------
doc/src/sgml/func.sgml | 27 ++----
src/backend/utils/adt/regproc.c | 195 +++++++++++-----------------------------
2 files changed, 63 insertions(+), 159 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Simplify the implementations of the to_reg* functions.
In-Reply-To: <E1pADp8-000h6b-7L@gemulon.postgresql.org>
References: <E1pADp8-000h6b-7L@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox