pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: perl: Hide warnings inside perl.h when using gcc compatible comp
6+ messages / 1 participants
[nested] [flat]

* pgsql: perl: Hide warnings inside perl.h when using gcc compatible comp
@ 2022-12-29 21:40 Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 6+ messages in thread

From: Andres Freund @ 2022-12-29 21:40 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

perl: Hide warnings inside perl.h when using gcc compatible compiler

New versions of perl trigger warnings within perl.h with our compiler
flags. At least -Wdeclaration-after-statement, -Wshadow=compatible-local are
known to be problematic.

To avoid these warnings, conditionally use #pragma GCC system_header before
including plperl.h.

Alternatively, we could add the include paths for problematic headers with
-isystem, but that is a larger hammer and is harder to search for.

A more granular alternative would be to use #pragma GCC diagnostic
push/ignored/pop, but gcc warns about unknown warnings being ignored, so every
to-be-ignored-temporarily compiler warning would require its own pg_config.h
symbol and #ifdef.

As the warnings are voluminous, it makes sense to backpatch this change. But
don't do so yet, we first want gather buildfarm coverage - it's e.g. possible
that some compiler claiming to be gcc compatible has issues with the pragma.

Author: Andres Freund <andres@anarazel.de>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: Discussion: https://postgr.es/m/20221228182455.hfdwd22zztvkojy2@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/388e80132c007a7528abc987e347e41432dc1542

Modified Files
--------------
src/include/c.h        | 28 ++++++++++++++++++++++++++++
src/pl/plperl/plperl.h |  9 +++++++++
2 files changed, 37 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: perl: Hide warnings inside perl.h when using gcc compatible comp
@ 2023-01-03 01:21 Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 6+ messages in thread

From: Andres Freund @ 2023-01-03 01:21 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

perl: Hide warnings inside perl.h when using gcc compatible compiler

New versions of perl trigger warnings within perl.h with our compiler
flags. At least -Wdeclaration-after-statement, -Wshadow=compatible-local are
known to be problematic.

To avoid these warnings, conditionally use #pragma GCC system_header before
including plperl.h.

Alternatively, we could add the include paths for problematic headers with
-isystem, but that is a larger hammer and is harder to search for.

A more granular alternative would be to use #pragma GCC diagnostic
push/ignored/pop, but gcc warns about unknown warnings being ignored, so every
to-be-ignored-temporarily compiler warning would require its own pg_config.h
symbol and #ifdef.

As the warnings are voluminous, it makes sense to backpatch this change. But
don't do so yet, we first want gather buildfarm coverage - it's e.g. possible
that some compiler claiming to be gcc compatible has issues with the pragma.

Author: Andres Freund <andres@anarazel.de>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: Discussion: https://postgr.es/m/20221228182455.hfdwd22zztvkojy2@awork3.anarazel.de

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c6e75e4c2703d8eb7cb14cbf94a3d3dc36fdabbd

Modified Files
--------------
src/include/c.h        | 28 ++++++++++++++++++++++++++++
src/pl/plperl/plperl.h |  9 +++++++++
2 files changed, 37 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: perl: Hide warnings inside perl.h when using gcc compatible comp
@ 2023-01-03 01:21 Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 6+ messages in thread

From: Andres Freund @ 2023-01-03 01:21 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

perl: Hide warnings inside perl.h when using gcc compatible compiler

New versions of perl trigger warnings within perl.h with our compiler
flags. At least -Wdeclaration-after-statement, -Wshadow=compatible-local are
known to be problematic.

To avoid these warnings, conditionally use #pragma GCC system_header before
including plperl.h.

Alternatively, we could add the include paths for problematic headers with
-isystem, but that is a larger hammer and is harder to search for.

A more granular alternative would be to use #pragma GCC diagnostic
push/ignored/pop, but gcc warns about unknown warnings being ignored, so every
to-be-ignored-temporarily compiler warning would require its own pg_config.h
symbol and #ifdef.

As the warnings are voluminous, it makes sense to backpatch this change. But
don't do so yet, we first want gather buildfarm coverage - it's e.g. possible
that some compiler claiming to be gcc compatible has issues with the pragma.

Author: Andres Freund <andres@anarazel.de>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: Discussion: https://postgr.es/m/20221228182455.hfdwd22zztvkojy2@awork3.anarazel.de

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7b5dec760f7d7cb8df0fe10051a6aca806581957

Modified Files
--------------
src/include/c.h        | 28 ++++++++++++++++++++++++++++
src/pl/plperl/plperl.h |  9 +++++++++
2 files changed, 37 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: perl: Hide warnings inside perl.h when using gcc compatible comp
@ 2023-01-03 01:21 Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 6+ messages in thread

From: Andres Freund @ 2023-01-03 01:21 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

perl: Hide warnings inside perl.h when using gcc compatible compiler

New versions of perl trigger warnings within perl.h with our compiler
flags. At least -Wdeclaration-after-statement, -Wshadow=compatible-local are
known to be problematic.

To avoid these warnings, conditionally use #pragma GCC system_header before
including plperl.h.

Alternatively, we could add the include paths for problematic headers with
-isystem, but that is a larger hammer and is harder to search for.

A more granular alternative would be to use #pragma GCC diagnostic
push/ignored/pop, but gcc warns about unknown warnings being ignored, so every
to-be-ignored-temporarily compiler warning would require its own pg_config.h
symbol and #ifdef.

As the warnings are voluminous, it makes sense to backpatch this change. But
don't do so yet, we first want gather buildfarm coverage - it's e.g. possible
that some compiler claiming to be gcc compatible has issues with the pragma.

Author: Andres Freund <andres@anarazel.de>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: Discussion: https://postgr.es/m/20221228182455.hfdwd22zztvkojy2@awork3.anarazel.de

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ce073d01445c09733ba71010276f1ef255b89efd

Modified Files
--------------
src/include/c.h        | 28 ++++++++++++++++++++++++++++
src/pl/plperl/plperl.h |  9 +++++++++
2 files changed, 37 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: perl: Hide warnings inside perl.h when using gcc compatible comp
@ 2023-01-03 01:21 Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 6+ messages in thread

From: Andres Freund @ 2023-01-03 01:21 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

perl: Hide warnings inside perl.h when using gcc compatible compiler

New versions of perl trigger warnings within perl.h with our compiler
flags. At least -Wdeclaration-after-statement, -Wshadow=compatible-local are
known to be problematic.

To avoid these warnings, conditionally use #pragma GCC system_header before
including plperl.h.

Alternatively, we could add the include paths for problematic headers with
-isystem, but that is a larger hammer and is harder to search for.

A more granular alternative would be to use #pragma GCC diagnostic
push/ignored/pop, but gcc warns about unknown warnings being ignored, so every
to-be-ignored-temporarily compiler warning would require its own pg_config.h
symbol and #ifdef.

As the warnings are voluminous, it makes sense to backpatch this change. But
don't do so yet, we first want gather buildfarm coverage - it's e.g. possible
that some compiler claiming to be gcc compatible has issues with the pragma.

Author: Andres Freund <andres@anarazel.de>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: Discussion: https://postgr.es/m/20221228182455.hfdwd22zztvkojy2@awork3.anarazel.de

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f0e13802f196bc1044d52669ae5ef0b32e3a4db2

Modified Files
--------------
src/include/c.h        | 28 ++++++++++++++++++++++++++++
src/pl/plperl/plperl.h |  9 +++++++++
2 files changed, 37 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: perl: Hide warnings inside perl.h when using gcc compatible comp
@ 2023-01-03 01:21 Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 6+ messages in thread

From: Andres Freund @ 2023-01-03 01:21 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

perl: Hide warnings inside perl.h when using gcc compatible compiler

New versions of perl trigger warnings within perl.h with our compiler
flags. At least -Wdeclaration-after-statement, -Wshadow=compatible-local are
known to be problematic.

To avoid these warnings, conditionally use #pragma GCC system_header before
including plperl.h.

Alternatively, we could add the include paths for problematic headers with
-isystem, but that is a larger hammer and is harder to search for.

A more granular alternative would be to use #pragma GCC diagnostic
push/ignored/pop, but gcc warns about unknown warnings being ignored, so every
to-be-ignored-temporarily compiler warning would require its own pg_config.h
symbol and #ifdef.

As the warnings are voluminous, it makes sense to backpatch this change. But
don't do so yet, we first want gather buildfarm coverage - it's e.g. possible
that some compiler claiming to be gcc compatible has issues with the pragma.

Author: Andres Freund <andres@anarazel.de>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: Discussion: https://postgr.es/m/20221228182455.hfdwd22zztvkojy2@awork3.anarazel.de

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/99f8bc335cbed43d64ed1e440a7fa43a8746a683

Modified Files
--------------
src/include/c.h        | 28 ++++++++++++++++++++++++++++
src/pl/plperl/plperl.h |  9 +++++++++
2 files changed, 37 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2023-01-03 01:21 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-12-29 21:40 pgsql: perl: Hide warnings inside perl.h when using gcc compatible comp Andres Freund <andres@anarazel.de>
2023-01-03 01:21 pgsql: perl: Hide warnings inside perl.h when using gcc compatible comp Andres Freund <andres@anarazel.de>
2023-01-03 01:21 pgsql: perl: Hide warnings inside perl.h when using gcc compatible comp Andres Freund <andres@anarazel.de>
2023-01-03 01:21 pgsql: perl: Hide warnings inside perl.h when using gcc compatible comp Andres Freund <andres@anarazel.de>
2023-01-03 01:21 pgsql: perl: Hide warnings inside perl.h when using gcc compatible comp Andres Freund <andres@anarazel.de>
2023-01-03 01:21 pgsql: perl: Hide warnings inside perl.h when using gcc compatible comp Andres Freund <andres@anarazel.de>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox