pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: perl: Hide warnings inside perl.h when using gcc compatible comp
Date: Tue, 03 Jan 2023 01:21:33 +0000
Message-ID: <E1pCVzh-001lFV-Gy@gemulon.postgresql.org> (raw)

perl: Hide warnings inside perl.h when using gcc compatible compiler

New versions of perl trigger warnings within perl.h with our compiler
flags. At least -Wdeclaration-after-statement, -Wshadow=compatible-local are
known to be problematic.

To avoid these warnings, conditionally use #pragma GCC system_header before
including plperl.h.

Alternatively, we could add the include paths for problematic headers with
-isystem, but that is a larger hammer and is harder to search for.

A more granular alternative would be to use #pragma GCC diagnostic
push/ignored/pop, but gcc warns about unknown warnings being ignored, so every
to-be-ignored-temporarily compiler warning would require its own pg_config.h
symbol and #ifdef.

As the warnings are voluminous, it makes sense to backpatch this change. But
don't do so yet, we first want gather buildfarm coverage - it's e.g. possible
that some compiler claiming to be gcc compatible has issues with the pragma.

Author: Andres Freund <andres@anarazel.de>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: Discussion: https://postgr.es/m/20221228182455.hfdwd22zztvkojy2@awork3.anarazel.de

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f0e13802f196bc1044d52669ae5ef0b32e3a4db2

Modified Files
--------------
src/include/c.h        | 28 ++++++++++++++++++++++++++++
src/pl/plperl/plperl.h |  9 +++++++++
2 files changed, 37 insertions(+)



view thread (6+ messages)  latest in thread

Message-ID: <E1pCVzh-001lFV-Gy@gemulon.postgresql.org>
Permalink:  ../E1pCVzh-001lFV-Gy@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pCVzh-001lFV-Gy@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: perl: Hide warnings inside perl.h when using gcc compatible comp
  In-Reply-To: <E1pCVzh-001lFV-Gy@gemulon.postgresql.org>
  References: <E1pCVzh-001lFV-Gy@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox