pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Check that xmax didn't commit in freeze check.
Date: Wed, 04 Jan 2023 05:49:13 +0000
Message-ID: <E1pCweH-001xRa-Hx@gemulon.postgresql.org> (raw)

Check that xmax didn't commit in freeze check.

We cannot rely on TransactionIdDidAbort here, since in general it may
report transactions that were in-progress at the time of an earlier hard
crash as not aborted, effectively behaving as if they were still in
progress even after crash recovery completes.  Go back to defensively
verifying that xmax didn't commit instead.

Oversight in commit 79d4bf4e.

Author: Peter Geoghegan <pg@bowt.ie>
Reported-By: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20230104035636.hy5djyr2as4gbc4q@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/eb5ad4ff05fd382ac98cab60b82f7fd6ce4cfeb8

Modified Files
--------------
src/backend/access/heap/heapam.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)



Message-ID: <E1pCweH-001xRa-Hx@gemulon.postgresql.org>
Permalink:  ../E1pCweH-001xRa-Hx@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pCweH-001xRa-Hx@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: pg@bowt.ie
  Subject: Re: pgsql: Check that xmax didn't commit in freeze check.
  In-Reply-To: <E1pCweH-001xRa-Hx@gemulon.postgresql.org>
  References: <E1pCweH-001xRa-Hx@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox