From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Upgrade the random.sql regression test.
Date: Tue, 10 Jan 2023 01:32:22 +0000
Message-ID: <E1pF3Uz-002tpr-MV@gemulon.postgresql.org> (raw)
Upgrade the random.sql regression test.
We had some pretty ad-hoc and inefficient code here. To make
matters worse, it didn't test the properties of the random()
function very thoroughly, and it had a test failure rate of
one in every few tens of thousands of runs. Replace the
script altogether with new test cases that prove much more
about random()'s output, run faster, and can be calculated
to have test failure rates on the order of 1e-9.
Having done that, the failure rate of this script should be
negligible in comparison to other causes of test failures,
so remove the "ignore" marker for it in parallel_schedule.
(If it does fail, we'd like to know about that, so "ignore"
was always pretty counterproductive.)
Tom Lane and Dean Rasheed
Discussion: https://postgr.es/m/4173840.1673290336@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/09d517773f606baef7958aa5bad25d3b3c30303e
Modified Files
--------------
src/test/regress/expected/random.out | 205 +++++++++++++++++++++++------------
src/test/regress/parallel_schedule | 3 -
src/test/regress/sql/random.sql | 123 ++++++++++++---------
3 files changed, 205 insertions(+), 126 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Upgrade the random.sql regression test.
In-Reply-To: <E1pF3Uz-002tpr-MV@gemulon.postgresql.org>
References: <E1pF3Uz-002tpr-MV@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox