pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve TransactionIdDidAbort() documentation.
Date: Wed, 11 Jan 2023 23:32:16 +0000
Message-ID: <E1pFkZr-003CBS-NP@gemulon.postgresql.org> (raw)

Improve TransactionIdDidAbort() documentation.

Document that TransactionIdDidAbort() won't indicate that transactions
that were in-progress during a crash have aborted.  Tie this to existing
discussion of the TransactionIdDidCommit() and TransactionIdDidCommit()
protocol that code in heapam_visibility.c (and a few other places) must
observe.

Follow-up to bugfix commit eb5ad4ff.

Author: Peter Geoghegan <pg@bowt.ie>
Reviewed-By: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/CAH2-Wzn4bEEqgmaUQL3aJ73yM9gAeK-wE4ngi7kjRjLztb+P0w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/af3855cb77b94a0321b77d7d9a9849700ea6a758

Modified Files
--------------
src/backend/access/heap/heapam_visibility.c | 33 ++++++++++++++++-------------
src/backend/access/transam/transam.c        |  9 +++++++-
2 files changed, 26 insertions(+), 16 deletions(-)



Message-ID: <E1pFkZr-003CBS-NP@gemulon.postgresql.org>
Permalink:  ../E1pFkZr-003CBS-NP@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pFkZr-003CBS-NP@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: pg@bowt.ie
  Subject: Re: pgsql: Improve TransactionIdDidAbort() documentation.
  In-Reply-To: <E1pFkZr-003CBS-NP@gemulon.postgresql.org>
  References: <E1pFkZr-003CBS-NP@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox